Repository navigation
Added library of land use classification color maps. - #2073
Merged
Merged
Conversation
…mps`. Signed-off-by: Simeon H.K. fitch <[email protected]>
Match wasn't catching `Error`. Both `Error` and `Failure` are the exclusive sub-types of `NoSuccess`, so changed match to that. Signed-off-by: Simeon H.K. fitch <[email protected]>
Member
Author
|
Travis error seems to have nothing to do with the actual build. Any way to re-trigger it? |
lossyrob
suggested changes
Mar 21, 2017
| @@ -0,0 +1,97 @@ | |||
| /* | |||
| * Copyright 2016 Azavea | |||
Member
There was a problem hiding this comment.
Since you/your company is submitting this file, this should be copyright to you or your company.
| defaultOptions | ||
| ) | ||
|
|
||
| private val defaultOptions = ColorMap.Options( |
Member
There was a problem hiding this comment.
Why not just use ColorMap.Options.DEFAULT?
Member
Author
There was a problem hiding this comment.
Since the noDataColor was the same as the DEFAULT, I'm removing that. However, I think the classBoundaryType should be EXACT, because operationally, you want to know if you have a classification assignment that's not part of your class set (sign of an error, or something else).
lossyrob
approved these changes
Mar 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.