Repository navigation
Remove Raster[T] to T implicit conversion - #2771
Merged
echeipesh merged 5 commits intoJul 31, 2018
Merged
Conversation
In particular this conversion results in data loss and surprising behavior
Contributor
Author
|
HA, this change actually revealed a bug in |
echeipesh
added a commit
that referenced
this pull request
Aug 5, 2018
Remove Raster[T] to T implicit conversion In particular this conversion results in data loss and surprising behavior (+2 squashed commits) Squashed commits: [da63873] Update tests where Raster[T] is used as T [750f159] fix: return grid aligned Extent on GeoTiff crop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular this conversion results in data loss and surprising behavior.
Other remaining implicit conversion, from
Raster[T]toPolygonFeature[T]at least preserve the extent information.Checklist
docs/CHANGELOG.rstupdated, if necessarydocsguides update, if necessaryDemo
Optional. Screenshots/REPL
Notes
Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.
Resolves #2768