Repository navigation
Made implicit conversions to/from Raster and ProjectedRaster deprecated. - #2834
Conversation
Partially addresses locationtech#2829. Signed-off-by: Simeon H.K. Fitch <[email protected]>
pomadchin
left a comment
pomadchin
left a comment
There was a problem hiding this comment.
LGTM, but I wrote a couple of non critical questions.
| /** | ||
| * Implicit conversion from a PolygonFeature to a [[Raster]]. | ||
| */ | ||
| @deprecated("Implicit conversions considered unsafe", "2.1.1") |
There was a problem hiding this comment.
I don't have a strong opinion about this deprecation warning. Can't we just remove them as we're preparing 3.0 release and definitely can break API?
There was a problem hiding this comment.
When you say "remove them" do you mean the @deprecation annotations, or the messages?
There was a problem hiding this comment.
Conversions, we can just mention in docs that we removed these implicits.
There was a problem hiding this comment.
Back-porting it and publishing the deprecation warnings with 2.1.1 is defiantly a good-guy move and we should do it.
There was a problem hiding this comment.
I'm still confused as to what you want me to do with this part.
|
NB: Build failed only due to one config timing out. |
|
If you're happy with the PR I say merge it. And yes, a separate PR for removal in 3.0 with appropriate changelog notice. |
Made implicit conversions to/from Raster and ProjectedRaster deprecated.
3 participants
Partially addresses #2829.