Skip to content

Fixed elliptical radius check in IDW algorithm. - #2844

Merged
pomadchin merged 1 commit into
locationtech:masterfrom
hhowe29:master
Dec 12, 2018
Merged

pomadchin merged 1 commit into
locationtech:masterfrom
hhowe29:master

Conversation

@hhowe29

@hhowe29 hhowe29 commented Dec 7, 2018

Copy link
Copy Markdown
Contributor

Overview

Closes #2840

Checklist

  • Unit tests added for bug-fix or new feature

@hhowe29
hhowe29 force-pushed the master branch 3 times, most recently from 38193e1 to e79121a Compare December 7, 2018 17:06

@pomadchin pomadchin left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! LGTM, @echeipesh do we need to sign up this PR?

@pomadchin

pomadchin commented Dec 12, 2018 •

Copy link
Copy Markdown
Member

Hey @hhowe29 I think that it's good to go even without CLA, but can you sign it? https://github.com/locationtech/geotrellis/blob/master/docs/CONTRIBUTING.rst#eclipse-contributor-agreement-eca

After signing just do git commit --amend -S && git push origin -f master

…orrectly. Fixes locationtech#2840.

Signed-off-by: Harold Howe <[email protected]>

Fix compilation error.
@hhowe29

hhowe29 commented Dec 12, 2018

Copy link
Copy Markdown
Contributor Author

@pomadchin Think I got it right this time.

@pomadchin

pomadchin commented Dec 12, 2018 •

Copy link
Copy Markdown
Member

@hhowe29 thank you so much; merging! 🎉 🎉 🎉 🎉

@pomadchin
pomadchin merged commit 8c02874 into locationtech:master Dec 12, 2018
echeipesh pushed a commit that referenced this pull request Dec 28, 2018
Fixed elliptical radius check in IDW algorithm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IDW interpolation radius check is incorrect

2 participants