Skip to content

Pixel is area sort x - #3192

Merged
echeipesh merged 3 commits into
locationtech:masterfrom
pmacleod:pixelIsArea_sortX
Apr 6, 2020
Merged

echeipesh merged 3 commits into
locationtech:masterfrom
pmacleod:pixelIsArea_sortX

Conversation

@pmacleod

Copy link
Copy Markdown
Contributor

Overview

In the polygon rasterizer, the PixelIsArea option causes runsArea to be used. This fix is to change how the edges are sorted so that they are in order of scanline interaction rather than leftmost X coordinate. This fixes a problem where some polygons containing concavities are filled incorrectly.

Checklist

  • docs/CHANGELOG.rst updated, if necessary
  • Module Hierarcy updated, if necessary
  • docs guides update, if necessary
  • New user API has useful Scaladoc strings
  • Unit tests added for bug-fix or new feature

Demo

Optional. Screenshots/REPL

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Closes #3187

@echeipesh
echeipesh merged commit 815b010 into locationtech:master Apr 6, 2020
echeipesh added a commit that referenced this pull request Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PixelIsArea fills in concavity

3 participants