Repository navigation
npm start failing on newly created lb4 app #1405
Description
Description / Steps to reproduce / Feature proposal
The app created following getting started guide is not in working state.
Current Behavior
Geting below exception when running npm start.
> lb-tsc
node_modules/@loopback/core/dist8/src/keys.d.ts:23:40 - error TS2307: Cannot find module '../../context/src/value-promise'.
23 const CONTROLLER_CLASS: BindingKey<import("../../context/src/value-promise").Constructor<any>>;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/@loopback/repository-json-schema/dist8/src/keys.d.ts:6:68 - error TS2307: Cannot find module '../../metadata/src/types'.
6 export declare const JSON_SCHEMA_KEY: MetadataAccessor<JSONSchema, import("../../metadata/src/types").DecoratorType>;
Expected Behavior
App should run without any issue
Activity
raymondfeng commentedon Jun 9, 2018
Hmm, it seems to be an issue related to TypeScript 2.9 (https://blogs.msdn.microsoft.com/typescript/2018/05/31/announcing-typescript-2-9/#import-types).
Running
npm run buildforloopback-next/packages/contextproduces an invalidkey.d.tsfromsrc/key.ts:Please note the relative import is invalid outside the monorepo.
chore(build): pin typescript version to 2.8.x
raymondfeng commentedon Jun 9, 2018
I'm proposing a workaround at #1406.
chore(build): pin typescript version to 2.8.x
raymondfeng commentedon Jun 9, 2018
Please try
npm i -g @loopback/[email protected]tapas4java commentedon Jun 10, 2018
Thanks @raymondfeng
@loopback/[email protected]looks fine.reyalpsirc commentedon Jul 26, 2018
Its failing again on
@loopback/[email protected]but with a different error now:reyalpsirc commentedon Jul 26, 2018
Okay, just found out that it fails with
node v8.2.1but withnode v8.3.0it does work. Maybe the docs should actually refer that the minimum node version is 8.3.0?shimks commentedon Jul 27, 2018
I've been able to reproduce the problem.
I see two options:
Object.assignWhat do you think @strongloop/sq-lb-apex, @bajtos, @raymondfeng?
bajtos commentedon Jul 30, 2018
Considering that Node.js 8.x LTS is at 8.11.3 now and 8.3.0 was released almost a year ago (2017-08-09) before 8.x entered LTS, I think it's acceptable to require our users to use 8.3.0 or newer.
I am proposing to update our docs and mention
8.9.0as the minimum required version (8.9.0was the first 8.x version covered by LTS). As part of this change, we should also update all of ourpackage.jsonfiles and modifyenginessection to use>=8.9instead of current>=8version spec for Node.