Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix the Bedrock export dependency stack (per title “Fix broken nbtx”) by stabilizing Bedrock-related Rust dependencies and updating the resolved dependency graph.
Changes:
- Pin
bedrockrs_level/bedrockrs_sharedto a specific upstream git revision. - Downgrade
rusty-leveldbto v3 for thebedrockfeature. - Regenerate
Cargo.lock, resulting in a large set of dependency version changes.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Cargo.toml |
Pins bedrock-rs git deps to a commit and switches rusty-leveldb to v3 for Bedrock feature builds. |
Cargo.lock |
Updates the resolved dependency set (including nbtx commit/version change and many unrelated transitive updates). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| bedrockrs_shared = { git = "https://github.com/bedrock-crustaceans/bedrock-rs", package = "bedrockrs_shared", optional = true } | ||
| bedrockrs_level = { git = "https://github.com/bedrock-crustaceans/bedrock-rs", rev = "7ef268b", package = "bedrockrs_level", optional = true } | ||
| bedrockrs_shared = { git = "https://github.com/bedrock-crustaceans/bedrock-rs", rev = "7ef268b", package = "bedrockrs_shared", optional = true } | ||
| nbtx = { git = "https://github.com/bedrock-crustaceans/nbtx", optional = true } |
There was a problem hiding this comment.
nbtx is still a floating git dependency (no rev/tag), while bedrockrs_* is pinned. To keep Bedrock builds reproducible and avoid future breakages when the nbtx repo updates, pin nbtx to a known-good rev (ideally matching the commit recorded in Cargo.lock).
| nbtx = { git = "https://github.com/bedrock-crustaceans/nbtx", optional = true } | |
| nbtx = { git = "https://github.com/bedrock-crustaceans/nbtx", rev = "REPLACE_WITH_NBTX_COMMIT_FROM_CARGO_LOCK", optional = true } |
|
⏱️ Benchmark run finished in 2m 4s 📈 Compared against baseline: 30s 🚨 This PR drastically worsens generation time. 📅 Last benchmark: 2026-04-04 11:13:55 UTC You can retrigger the benchmark by commenting |
Resolve conflicts in Cargo.toml and Cargo.lock: keep main's nbtx (no rev pin, already fixed in main via #879). Co-Authored-By: Claude Opus 4.6 <[email protected]>
No description provided.