Repository navigation
Add Missing HTML5 Tags - #48
Merged
smtlaissezfaire merged 8 commits intoJun 14, 2024
Merged
Conversation
smtlaissezfaire
self-requested a review
June 14, 2024 04:45
smtlaissezfaire
approved these changes
Jun 14, 2024
smtlaissezfaire
left a comment
smtlaissezfaire
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for the submission. Sorry for the super long delay into looking at this; this project hasn't really been on my radar for a while.
Contributor
Author
|
Haha all good, I'm glad it got in! Now I can continue working on my blog, this was a huge blocker for me 🤣 😎 |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jun 15, 2024
0.9.4 (2024-06-14) * Earlopain - Fix compatibility with latest builder release #49 * github.com/markaby/markaby/pull/49 * Aesthetikx Add Missing HTML5 Tags #48 - github.com/markaby/markaby/pull/48 * MrPowers - Small Refactorings - github.com/markaby/markaby/pull/50, github.com/markaby/markaby/pull/34
msk
pushed a commit
to msk/pkgsrc
that referenced
this pull request
May 11, 2026
0.9.4 (2024-06-14) * Earlopain - Fix compatibility with latest builder release NetBSD#49 * github.com/markaby/markaby/pull/49 * Aesthetikx Add Missing HTML5 Tags NetBSD#48 - github.com/markaby/markaby/pull/48 * MrPowers - Small Refactorings - github.com/markaby/markaby/pull/50, github.com/markaby/markaby/pull/34
jperkin
pushed a commit
to TritonDataCenter/pkgsrc
that referenced
this pull request
May 14, 2026
0.9.4 (2024-06-14) * Earlopain - Fix compatibility with latest builder release #49 * github.com/markaby/markaby/pull/49 * Aesthetikx Add Missing HTML5 Tags #48 - github.com/markaby/markaby/pull/48 * MrPowers - Small Refactorings - github.com/markaby/markaby/pull/50, github.com/markaby/markaby/pull/34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit 85e1961 and then 0872596 added a fair amount of the tags present in the HTML5 spec, but there are still some missing. The one I really wanted was
<main>, but I figured I would finish the list. I added, as far as I could tell, the ones that were missing, as well as their custom attributes, if any.🦊 🦊 🥓