Skip to content

Missing preferences menu #56

Description

@fxha

The "Marktext" application menu is not shown on OSs other than OSX. Maybe we could move the preferences entry into file or edit menu, so that you can edit preferences on Linux and Windows?

Versions

  • Mark Text: latest
  • OS: not OSX

Activity

  1. Jocs commented on Mar 22, 2018

    @Jocs
    Member

    @fxha Does use Ctrl + , shortcut work ?

  2. fxha commented on Mar 22, 2018

    @fxha
    ContributorAuthor

    I don't think so, because see here.

    Edit: It does not work on linux

  3. Jocs commented on Mar 22, 2018

    @Jocs
    Member

    @fxha Aha, I forget I just add Mart Text menu to OS X system, Because I only have Mac OS X system, So I can not test whether it is work when add Mark Text menu to other system.

    If it not work, Add preference menu item to file menu in Windows and Linux systems.

    if (platform !== 'darwin') {
        // add preferences to file menu
    }

    Can you fix this problem?

  4. fxha commented on Mar 22, 2018

    @fxha
    ContributorAuthor

    Only preferences, update and quit works. Is that correct?

    mt_menu

    Edit: My theme hides menu separators.

  5. Jocs commented on Mar 22, 2018

    @Jocs
    Member

    Can you hide About Mark Text, Services, Hide Mark Text, Hide Others, Show All menu items when Mart Text in Windows and Linux ? or other idea?

  6. fxha commented on Mar 22, 2018

    @fxha
    ContributorAuthor

    Btw. what does Services do? For About Mark Text we could display a message box and hide the others or add preferences and quit to file and check for updates to help.

    Can you send me a screenshot from about dialog?

  7. Jocs commented on Mar 22, 2018

    @Jocs
    Member

    1521732701833

    Just like this.

    Many Apps in Mac, have a APP name menu, and have about, services, quit, 'check for update' etc, in this menu. But I don't know how to display these menu item in Windows or Linux.

  8. Jocs commented on Mar 22, 2018

    @Jocs
    Member

    @fxha But I think when user click About..., show them a message box in the render process. this is a good idea. and not use this build in message box.

  9. fxha commented on Mar 22, 2018

    @fxha
    ContributorAuthor

    mt_dd

    mt_about

    I have problems with the icon/information, but I will check that on Windows. Maybe replace the message box with a custom design (#58).

  10. Jocs commented on Mar 22, 2018

    @Jocs
    Member

    @fxha I prefer use dialog in element-ui to show the About info. just like this. Because Mark Text has already used it.

    about

  11. SuperSandro2000 commented on Mar 22, 2018

    @SuperSandro2000
    Contributor

    I would reorder it like:
    Preferences
    Check for updates
    About mark text

  12. fxha commented on Mar 22, 2018

    @fxha
    ContributorAuthor

    I changed my mind and added preferences and quit to the file menu and update and about to Help on Linux and Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    🐝 resolved/fixed but not releasedThe bug has been fixed and the new version is not released, So it still opened🦁 need discussthe issue or PR need to discuss

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions