Skip to content

Table menu bug聽#67

Description

@fxha

Description

The table menu icon disappears and you can move the menu 馃檲.

Steps to reproduce

problem 1 (fixed)

  1. create table
  2. press Ctrl+A
  3. press Del
  4. table icon disappears

mt_bug_table_remove

problem 2

  1. create table
  2. press Ctrl+A
  3. press (multiple times) Enter
  4. table menu position changes and you cannot click on the table anymore

mt_bug_table_enter

problem 3

  1. create table
  2. insert new line after the table
  3. select table cell
  4. press Ctrl+A
  5. press Del
  6. table disappears

mt_bug_table_rm

StateRender.js?8779:formatted:140 Uncaught TypeError: Cannot read property 'align' of undefined
    at renderBlock (StateRender.js?8779:formatted:140)
    at eval (StateRender.js?8779:formatted:170)
    at Array.map (<anonymous>)
    at renderBlock (StateRender.js?8779:formatted:169)
    at eval (StateRender.js?8779:formatted:170)
    at Array.map (<anonymous>)
    at renderBlock (StateRender.js?8779:formatted:169)
    at eval (StateRender.js?8779:formatted:170)
    at Array.map (<anonymous>)
    at renderBlock (StateRender.js?8779:formatted:169)
if (block.type === 'li' && block.label) { <--- error
          const { label } = block
          const { align } = activeBlocks[0]

          if (align && block.label === align) {
            blockSelector += '.active'
          }
          Object.assign(data.dataset, { label })
        }

problem 4 (fixed)

  1. create table
  2. insert new line after table
  3. select table cell
  4. press Ctrl+A
  5. press Backspace
  6. press Ctrl+A
  7. press Backspace
Uncaught TypeError: Cannot read property 'textContent' of undefined
    at checkEditLanguage (language.js?430e:5)
    at HTMLDivElement.handler (index.js?981b:190)
/**
 * check edit language
 */
export const checkEditLanguage = (paragraph, selectionState) => {
  const text = paragraph.textContent <--- error
  const { start } = selectionState
  const token = text.match(/(^`{3,})([^`]+)/)

  if (token) {
    const len = token[1].length
    const lang = token[2].trim()
    if (start < len) return false
    if (!lang) return false
    return lang
  } else {
    return false
  }
}

// WEBPACK FOOTER //
// src/editor/codeMirror/language.js

Versions

  • Mark Text: 0.8.8
  • OS: linux

Activity

  1. Jocs commented on Mar 23, 2018

    @Jocs
    Member

    @fxha Style in the create table dialog is also wrong in Linux system.

  2. Jocs commented on Mar 23, 2018

    @Jocs
    Member

    @fxha So many weird bugs, these bugs will make me crazy...

  3. fxha commented on Mar 23, 2018

    @fxha
    ContributorAuthor

    Style in the create table dialog is also wrong in Linux system.

    What did you mean by this?

  4. Jocs commented on Mar 23, 2018

    @Jocs
    Member

    the row input and the column input are not in the same row.
    they display in two lines.

    They should display in one row. like this:

    Row: __________ Column __________

  5. Jocs commented on Apr 12, 2018

    @Jocs
    Member

    @fxha

    1. select table row/column

    how to select table row/column?

  6. added a commit that references this issue on Apr 12, 2018
  7. fxha commented on Apr 12, 2018

    @fxha
    ContributorAuthor

    @Jocs I mean table cell

  8. Jocs commented on Apr 12, 2018

    @Jocs
    Member

    @fxha I can not reproduce the problem 3, can you help test it with the latest master branch. I have submitted a commit to fix this issue.

  9. fxha commented on Apr 12, 2018

    @fxha
    ContributorAuthor

    @Jocs I updated issue and found a new bug

  10. 2 remaining items

  11. added
    馃悵 resolved/fixed but not releasedThe bug has been fixed and the new version is not released, So it still opened
    and removed
    馃悰 bugSomething isn't working
    on Apr 16, 2018
  12. Jocs commented on Apr 16, 2018

    @Jocs
    Member

    @fxha fixed in master branch

  13. fxha commented on Apr 16, 2018

    @fxha
    ContributorAuthor

    @Jocs Thanks for your work, but problem 2 and 3 still exists in master branch.

  14. Jocs commented on Apr 16, 2018

    @Jocs
    Member

    @fxha I found that if wrote the commit message fix: #xxx, and the xxx issue will be automatically closed, I'll reopen this issue to fix the problem 2 and 3.

  15. reopened this on Apr 16, 2018
  16. added
    馃悰 bugSomething isn't working
    馃 pri/majorBugs will affect your normal use of Mark Text, causing you unwilling or unable to continue using MT
    on May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    馃 pri/majorBugs will affect your normal use of Mark Text, causing you unwilling or unable to continue using MT馃悰 bugSomething isn't working馃 table blockissues about table block

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions