Repository navigation
fix: restore editor visual parity after @muyajs/core migration - #4443
Merged
Merged
Conversation
|
Build artifacts for PR #4443: Run: https://github.com/marktext/marktext/actions/runs/27270915848
|
…oll buffer After the @muyajs/core migration (#4406) the legacy `#ag-editor-id` padding no longer matched the new `.mu-container`, so the first block sat ~20px too close to the top and the document lost its 100vh bottom scroll buffer. Restore both on `.editor-component .mu-container`. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
…flow:hidden The drop-shadow icon technique shifts the source PNG off-screen and projects a recoloured silhouette back into view. `overflow: auto` on the icon box let the host app's global `::-webkit-scrollbar` styling force a classic, space-taking scrollbar that filled the ~14px box (rendering as a gray square) and hid the table-column toolbar, code/math copy and several other icons. The muya examples were unaffected because they don't style scrollbars (macOS overlay scrollbars take no space). Switch every icon `i.icon` box to `overflow: hidden`, matching the already -correct inline-format toolbar. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Match the legacy muyajs look on the new `.mu-*` DOM: - paragraph/block spacing back to collapsing `margin: 0.5em 0` (was non-collapsing `padding: 0.5em 0`, which doubled the gap between blocks) - headings to `margin: 1rem 0` - divider (thematic break) to 2px dashed, vertically centred - ordered/bullet/task list indent to 30px - blockquote to `0 30px` padding + 2px bar at left:15px, full height - task-list checked marker to `--theme-color` + selection glow; loose checkbox top back to 0.3em; drop the engine's extra `li padding-left` Colours flow through the existing per-theme camelCase->kebab variable bridge, so this applies uniformly across all themes. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Jocs
force-pushed
the
fix/muya-editor-visual-parity
branch
from
June 10, 2026 10:46
d21ab16 to
e029713
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the
@muyajs/coreengine migration (#4406) the desktop editor picked up the new engine's.mu-*design language, which diverged from the legacy marktext look in several places. This restores parity. Three self-contained commits:1.
fix(desktop)— first-paragraph top spacing + bottom scroll bufferThe legacy
#ag-editor-idpadding no longer matched the new.mu-container, so the first block sat ~20px too close to the top and the doc lost its 100vh bottom scroll buffer. Restored on.editor-component .mu-container.2.
fix(muya)— render toolbar/copy icons (overflow:auto → hidden)The drop-shadow icon trick shifts the source PNG off-screen.
overflow: autoon the tiny icon box let the desktop's global::-webkit-scrollbarstyling force a classic, space-taking scrollbar that filled the ~14px box (a gray square), hiding the table-column toolbar, code/math copy and other icons. The muya examples were unaffected (no scrollbar styling → macOS overlay scrollbars). All iconi.iconboxes now useoverflow: hidden, matching the already-correct inline-format toolbar.3.
fix(muya)— block-level content styling parity across themesMatch the legacy muyajs look on the new
.mu-*DOM:margin: 0.5em 0(was non-collapsingpadding, which doubled the gap)margin: 1rem 00 30pxpadding + 2px bar atleft:15px, full height--theme-color+ selection glow; loose checkboxtop: 0.3emColours flow through the existing per-theme camelCase→kebab variable bridge, so this applies uniformly across all 32 themes.
Verification
stylelintclean on the changed muya CSS (0 errors).Open question (not addressed here)
The new engine colours bullet
::markers with--list-marker-color(theme accent), whereas the old engine left them text-coloured. Left as-is since it's a deliberate themable feature, not clearly a regression — happy to revert to text-coloured bullets if preferred.🤖 Generated with Claude Code