Repository navigation
fix(desktop): keep exported links working from folders named with #, ? or % - #5320
Conversation
…? or % resolveLocalLinkHref joined the raw window.DIRNAME into a file:// URL, so a `#` or `?` in the document's folder name started a fragment or query in the exported HTML / PDF link, and a literal `%xx` in the name was percent-decoded. Escape those characters in the directory only, as getImageSrc does in muya since marktext#5301: the markdown link is already URL-form and keeps its own fragment.
Jocs
left a comment
Jocs
left a comment
There was a problem hiding this comment.
Verified the bug and the fix on macOS against a real export, not only the unit tests. A document in C# 100%25 what?/ exported to styled HTML and PDF from develop has every relative link cut off at /C, and clicking one in Chrome opens an error page. The PR build produces C%23 100%2525 what%3F/… links that open the right file and keep their own #fragment. Links from ordinary folders (plain-dir, my notes 中文) are unchanged. The three new specs fail on develop and pass with the change.
Non-blocking: when you do the resolveLocalImageSrc follow-up, which has the same bug (an exported <img> from that folder fails to load), consider moving encodeDirnameForUrl into a shared desktop util rather than adding a third copy.
Thanks!
… ? or % (#5335) (#5337) resolveLocalImageSrc joined the raw window.DIRNAME into a file:// URL, so a `#` or `?` in the document's folder name started a fragment or query in the exported HTML / PDF image, and a literal `%xx` in the name was percent-decoded. Escape those characters in the directory only, as resolveLocalLinkHref does since #5320: the markdown image path is already URL-form and keeps its own query and escapes. localPathToFileUrl and encodeDirnameForUrl move into util/fileUrl.ts so the image and link resolvers share them. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_019p11VSo6R74VD94ezRFNGb
2 participants
No issue filed for this one; it is the export-side twin of #5212 / #5301.
Summary
After #5301 fixed relative images in the editor for documents living in a folder named with
#,?or%, I looked for other places that build afile://URL fromwindow.DIRNAMEand foundresolveLocalLinkHref, which rewrites relative links when exporting to styled HTML or PDF (#1688). It still pastes the raw directory into the URL.With a document in
/home/me/C# 100%25 what?/and a link[notes](./notes.md), the exported link isfile:///home/me/C# 100%25 what?/notes.md. A browser reads that as the path/home/me/C, a fragment starting at#, and%25gets decoded to%, so the link points nowhere once the HTML is opened.The fix is the same as in muya's
getImageSrc: escape%,?and#in the directory only. The markdown href is already URL-form, so it is left alone and keeps its own#fragmentand%20-style escapes.Type of change
Test plan
test/unit/specs/resolveLinkHref.spec.tscovers the escaped directory, a link that carries its own fragment and%20, and checks thatnew URL()on the result gives back the real path with no hash or query. All three fail ondevelopand pass with the change;exportHtml.spec.tsandexport-header-footer-diagram.spec.tsstill pass, andpnpm run lint/pnpm run typecheckare clean.Notes for reviewers [optional]
The same raw
window.DIRNAMEjoin exists for images inutil/resolveImageSrc.ts(resolveLocalImageSrc, used by export and print). I left it out because that file is already modified by the open #4789 and I did not want to conflict with it; happy to follow up once that settles.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
AI tools used