fix(desktop): restore treePathExcludePatterns filtering in the sidebar tree - #5461

Fixes #5159.

Reproduced

On develop, with a temp project holding alpha.md, beta.md and nested/gamma.md, driving the real EditorWindow.openFolder path (watcher IPC + mt::open-directory) in a Playwright-attached build:

The main process logs, once per traversal step:

Error while watching files: TypeError: minimatchExports.minimatch is not a function
    at checkPathExcludePattern (out/main/index.js:1560:26)
    at ignored (out/main/index.js:5672:13)
    at matchPatterns ([email protected]/index.js:61:13)
    at FSWatcher._isIgnored ([email protected]/index.js:668:21)
    at NodeFsHandler._addToNodeFs ([email protected]/handler.js:583:26)

Same result against the electron-builder packaged .app.

Root cause

packages/desktop/src/common/filesystem/paths.ts imports { minimatch } from 'minimatch', but minimatch was never a declared dependency — it has been a phantom dependency since #4001 introduced the import. With shamefully-hoist=true it resolved to whichever transitive copy won the root node_modules hoist, here minimatch@3, whose CommonJS export is the function itself:

module.exports = minimatch
minimatch.Minimatch = Minimatch
// no `minimatch.minimatch`

so the named import was undefined.

packages/desktop/src/types/shims.d.ts hand-declared the module:

declare module 'minimatch' {
  export function minimatch(target: string, pattern: string, options?: unknown): boolean
}

which is why typecheck and lint stayed green over a binding that could never exist at runtime.

checkPathExcludePattern only reaches the call inside its pattern loop, so an empty array short-circuits and works, while any non-empty value throws TypeError: minimatch is not a function. The sidebar watcher calls it from chokidar's ignored predicate, where the throw aborts the initial traversal — chokidar emits error instead of the addDir/add events the renderer's project store builds the tree from, so the sidebar stays empty.

This matches the report's note that isolating the release-bundled chokidar did not reproduce it: chokidar is fine, and so is minimatch — the break is the module boundary between them.

Fix

Declare minimatch as a real dependency of packages/desktop and drop the shim so the package's own types apply. minimatch@9 ships dual CJS/ESM with a real named export, and require("minimatch").minimatch is what the bundled main process now calls. (Pinned to 9 rather than 10: minimatch 10 relicensed to BlueOak-1.0.0, which validate-licenses rejects. 9.0.9 is still ISC.)

Side effect worth noting: treePathExcludePatterns filters for the first time since #4001 — previously it either did nothing (empty) or emptied the tree (non-empty).

Verification

• New unit spec path-exclude-pattern.spec.ts — fails on develop with TypeError: minimatch is not a function on every non-empty pattern case.
• pnpm test:unit — 826 passed / 61 files.
• pnpm typecheck, pnpm lint — clean (0 errors).
• electron-builder --dir: minimatch present under app.asar/node_modules/minimatch, and the packaged app filters correctly.
• pnpm validate-licenses — clean.

🤖 Generated with Claude Code