Repository navigation
RFC: Create a common usocket_mphal #4475
Description
We currently have 4 different modusocket implementations, all supposed to expose the exact same interface.
I believe lots of the code can be shared. There's lot of parameters handling and conversion between mp_obj_t to simple data types, and vice versa. Most of the systems do expose a BSD sockets API, or, at least, their API can be easily wrapped to achieve the BSD sockets API.
Having multiple implementations of the pythonic API is bad because things go wrong and little inconsistencies show up between different ports. Generally I think the pythonic API should be implemented only once, so having a file like utime_mphal.c is a nicer way.
Also, when the python API impl is done, it's easier to now implement it for more ports.
Would modusocket_mphal.c do it?
Activity
dpgeorge commentedon Feb 8, 2019
The problem with unifying the
usocketimplementations in that the ports usually have different underlying implementations with subtle differences that need to be accounted for. Currently there are 3 broad classes ofusocketcode:extmod/modlwip.cwhich directly wraps the low-level interface provided by lwIP, so that threads are not needed.usocketcode could be combined.If some kind of unification was done (which is a good thing to consider) then it would be very important to retain the efficiency of how (1) is currently implemented.
dpgeorge commentedon Feb 8, 2019
Sorry, closed in error.
Jongy commentedon Feb 9, 2019
I'll give it a shot while keeping in mind about efficiency and code size (which tend to get hurt while generalizing stuff). Start with something small and see if we find it useful.
jonnor commentedon Oct 3, 2025
Is this still relevant?
dpgeorge commentedon Oct 4, 2025
This is something that still could be done, probably following how the
machinemodule classes have been factored out intoextmod/machine_*.ccode.But since there's been no activity here, I'll close the issue for now.