Repository navigation
Conversation
Contributor
|
Thanks for the patch.
We standardize on using DER format, as both minimal itself and requiring less code. There're also various codestyle issues, please see https://github.com/micropython/micropython/blob/master/CODECONVENTIONS.md . |
pfalcon
suggested changes
Feb 17, 2019
pfalcon
left a comment
pfalcon
left a comment
Contributor
There was a problem hiding this comment.
Recommended changes per the comment above.
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Mar 18, 2021
Add board definition for Sparkfun Pro Micro RP2040
Member
|
This is a good feature, but the implementation here is lacking, it needs a test, raise exceptions instead of printf, and fixed code styling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables to use the ESP32 (maybe also the ESP8266) with https and CA validation:
Example:
https://github.com/Kradxn/esp32ssltest
I also propose a complete rewrite of that file, because its implementation doesn't reflect the ussl documentation.
But for now this works.
s = ussl.wrap_socket(s, ca_certs=cert, server_hostname=host)cert has to be (like the other cert) a string with a certificate in pem format
e.g. for google.com: