Repository navigation
STM32H7: FDCAN Fixes - #6212
Closed
iabdalkader wants to merge 6 commits into
Closed
STM32H7: FDCAN Fixes#6212iabdalkader wants to merge 6 commits into
iabdalkader wants to merge 6 commits into
Conversation
iabdalkader
commented
Jun 30, 2020
iabdalkader
commented
Contributor
- Fix fdcan can_receive fifo0 was used for both fifo0 and fifo1.
- Check if timeout == HAL_MAX_DELAY in fdcan can_receive.
- Cleanup use FDCAN_RXFxS_FxFL instead of hard-coded value.
- Handle the timeout arg for FDCAN in pyb_can_send as specified in the docs.
* Use the right FIFO to calculate element address.
…docs. * Following the documented pyb can_send behavior here: http://docs.micropython.org/en/latest/library/pyb.CAN.html?highlight=can%20send#pyb.CAN.send
dpgeorge
reviewed
Jul 8, 2020
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.