Repository navigation
Conversation
tve
marked this pull request as ready for review
November 12, 2020 06:26
This was referenced Dec 24, 2020
Member
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Jul 26, 2022
1. Run the socket select task at the same priority as CP. This is needed because it queues up the background work. Without it, CP needed to sleep to let the lower priority task go. 2. Close the active socket on disconnect. This prevents looping over a disconnected but not closed socket. Fixes micropython#6610. Fixes micropython#6613
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces #5968 and #6569, which attempted to patch-up the error codes.
This PR is based on the esp32-idf41-cmake branch and thus uses the cmake build system.
The main change brought about by this PR is to set
MICROPY_USE_INTERNAL_ERRNO=0to use the compiler's errno.h inxtensa-esp32-elf/sys-include/sysfrmo the xtensa build tools.It also removes the error code switcharoo in modsocket.c