Repository navigation
Conversation
And the extmod implementation does not work for file descriptors I guess? Perhaps add a check that only one of the implementations gets selected, just to avoid linker errors? |
There was a problem hiding this comment.
I'm wondering why this is needed. py/objmodule.c already includes this module when MICROPY_PY_USELECT is enabled. Isn't that enough?
There was a problem hiding this comment.
Yep, you're right. Reverted.
Signed-off-by: Jim Mussared <[email protected]>
Signed-off-by: Jim Mussared <[email protected]>
84111fe to
f8d616e
Compare
That's right. It's relatively straightforward to add MP_STREAM_POLL to unix/modusocket.c and extmod/vfs_posix_file.c if this is important in the future.
Good thinking. Done |
web workflow file system page
3 participants
The unix implementation of uselect only works with file descriptors (i.e. cannot work on user-defined streams).
This PR allows the unix port to be built with the implementation of uselect that we use on bare-metal ports (which does allow this).