Repository navigation
Additional S2 support + new S2 boards (v2) - #7222
Conversation
There was a problem hiding this comment.
@UnexpectedMaker why is this needed? surely it needs a proper implementation :)
There was a problem hiding this comment.
That was what we added when we did that video call a while back as something in the compiler was looking for it and it was falling over without it.
There was a problem hiding this comment.
Oh, I don't remember that! Do you have any S3 board definitions that compile?
There was a problem hiding this comment.
I'll need to test out my S3 board again today and I'll get back to you with files for a working S3 board.
There was a problem hiding this comment.
Oh, I don't remember that! Do you have any S3 board definitions that compile?
I've not had a chance to look into this yet, sorry. Feel free to remove it for now as its S3 specific only.
There was a problem hiding this comment.
Ok, removed this for now.
|
Thanks for re-jigging my PR commits :) |
91b01bd to
48c2e24
Compare
Improvements made: - PSRAM support for S2 - partition definition for 16MiB flash - correct ADC and DAC pins - correct GPIO and IRQ pins - S3 components in CMakeLists Based on original commit made by Seon Rozenblum aka @UnexpectedMaker. Signed-off-by: Damien George <[email protected]>
And add default hardware SPI 0 pins in mpconfigboard.h, and CONFIG_LWIP_LOCAL_HOSTNAME in sdkconfig.board.
Based on original commit made by Seon Rozenblum aka @UnexpectedMaker. Signed-off-by: Damien George <[email protected]>
48c2e24 to
0e87459
Compare
|
Thanks @dpgeorge ! |
2 participants
This is a rework of #7163 to tidy up the commits.