Repository navigation
checkJs too strict about module.exports assignment #15647
Copy link
Copy link
Closed
Labels
BugA bug in TypeScriptA bug in TypeScriptFixedA PR has been merged for this issueA PR has been merged for this issue
Milestone
Description
Activity
- assigned and unassigned
on Aug 31, 2017 This is a blocker for webpack/webpack#6862
Nathan Shively-Sanders (@sandersn) Daniel Rosenwasser (@DanielRosenwasser)
Thanks!- added a commit that references this issue
on Apr 8, 2018 #23228 Should fix this. Can you try typescript@next?
Reacted by Mohsen Azimi- addedFixedA PR has been merged for this issueA PR has been merged for this issue
on Apr 9, 2018 - added a commit that references this issue
on Apr 11, 2018 Nathan Shively-Sanders (@sandersn) Your changes resolved this! Thank you!
The only thing that's still erroring is this:
exports = module.exports = webpack;
Mohsen Azimi (@mohsen1) #23319 should fix this. give it a try in tommrow's build.
Reacted by Mohsen Azimi- added a commit that references this issue
on Apr 12, 2018 - locked and limited conversation to collaborators
on Jul 25, 2018
Metadata
Metadata
Assignees
Labels
BugA bug in TypeScriptA bug in TypeScriptFixedA PR has been merged for this issueA PR has been merged for this issue
I was trying to run with
// @ts-checkon a webpack config file. Unfortunately, it choked on the following simplified repro:I get