Repository navigation
Allow exports assignments - #23319
Merged
Nathan Shively-Sanders (sandersn) merged 1 commit intoApr 11, 2018
Merged
Nathan Shively-Sanders (sandersn) merged 1 commit into
Nathan Shively-Sanders (sandersn) merged 1 commit into
Conversation
1. Allow assignment to `exports`. 2. The type of the rhs is not checked against the type of `exports` since they are aliased declarations. To support more complex patterns like `exports = c.name = c`, we may have to treat `c.name` as a declaration. That will be more complicated than this PR.
Nathan Shively-Sanders (sandersn)
requested review from
Mohamed Hegazy (mhegazy) and
Wesley Wigham (weswigham)
April 10, 2018 21:30
Wesley Wigham (weswigham)
approved these changes
Apr 11, 2018
Nathan Shively-Sanders (sandersn)
deleted the
js/allow-exports-property-assignments
branch
April 11, 2018 13:50
Tobias Koppers (sokra)
added a commit
to webpack/webpack
that referenced
this pull request
Apr 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just removes some bogus errors in the checker. The binding itself has already been fixed.
exports.exportssince they are aliased declarations.To support more complex patterns like
exports = c.name = c(see #22459), we may have to treatc.nameas a declaration. That will be more complicated than this PR.Fixes #22436