variable name _this breaks in checkJs #22866

Activity

1. mhegazy commented on Mar 26, 2018

   

   Mohamed Hegazy (mhegazy)

   on Mar 26, 2018

   Contributor

   More actions

   Here is a simplified repro:

   // @ts-check
   
   class Base { }
   
   class C extends Base {
       constructor() {
           super();
       }
   
       foo() {
           let _this = this;
           
           () => {
               _this
           };
       }
       
   }
2. Mohamed Hegazy (mhegazy)

   added

   BugA bug in TypeScriptA bug in TypeScript

   Salsa

   on Mar 26, 2018
3. Mohamed Hegazy (mhegazy)

   assigned

   Nathan Shively-Sanders (sandersn)

   on Mar 26, 2018
4. Mohamed Hegazy (mhegazy)

   added this to the TypeScript 2.9 milestone on Mar 26, 2018
5. Mohamed Hegazy (mhegazy)

   added a commit that references this issue on Mar 26, 2018

   Fix #22866: Condition checking for name collision of generated variab…

   ...

   This issue will close once commit 7fd602e is merged into the 'main' branch.

   7fd602e
6. Mohamed Hegazy (mhegazy)

   assigned

   Mohamed Hegazy (mhegazy)

   and unassigned

   Nathan Shively-Sanders (sandersn)

   on Mar 26, 2018
7. Mohamed Hegazy (mhegazy)

   added

   FixedA PR has been merged for this issueA PR has been merged for this issue

   on Mar 26, 2018
8. Mohamed Hegazy (mhegazy)

   closed this as completedin #22886on Mar 26, 2018
9. mhegazy commented on Mar 26, 2018

   

   Mohamed Hegazy (mhegazy)

   on Mar 26, 2018

   Contributor

   More actions

   Mohsen Azimi (@mohsen1) fix should be in tonight's typescript@next.
10. Mohamed Hegazy (mhegazy)

    added a commit that references this issue on Mar 26, 2018

    Merge pull request #22886 from Microsoft/Fix22866

    ...

    This issue will close once commit faa3fca is merged into the 'main' branch.

    faa3fca
11. microsoft

    locked and limited conversation to collaborators on Jul 25, 2018