Repository navigation
Mirror Cursor for JSX #51832
Description
Activity
Pine (@octref) Finally, amazing news!
Reacted by Nicolas BarraudPine (@octref) Can you please share a link to the code that implements this feature for html?
Reacted by Tobias HernstigThe client side implementation is more complicated: https://github.com/microsoft/vscode/blob/master/extensions/html-language-features/client/src/mirrorCursor.ts
The server side is pretty easy, just need to compute mirror position: https://github.com/microsoft/vscode-html-languageservice/blob/master/src/services/htmlMatchingTagPosition.ts
Reacted by Tobias Hernstig and Seyyed Mahdi- changed the title
[-]JSX support for auto rename tag[/-][+]Mirror Cursor for JSX[/+]on Dec 13, 2019 I would like to suggest an option for the languages that this feature can apply to. I work with XSL file and there is no mirror cursor. I could change the language to HTML, but I would loose formatting, highlighting, etc.. for XSL.
Reacted by SalmanAlSaigalEdx, Alexandre Leduc, Cody Robertson, Catarina Machado, Agostino Carandente, Dusan Radovanovic, Richard Moore, tamasys, Leo Burceacov, Abhijit Hota and 12 moreReacted by Rob OLeary and Biel Simon Rojas- changed the title
[-]Mirror Cursor for JSX[/-][+][rename on type] Mirror Cursor for JSX[/+]on May 4, 2020 - changed the title
[-][rename on type] Mirror Cursor for JSX[/-][+]Mirror Cursor for JSX[/+]on May 4, 2020 24 remaining items
- added a commit that references this issue
on Mar 6, 2023 Isabel Duan (@iisaduan) I've updated the proposed protocol to more closely match VS Code / LSP. Here's the LSP linked editing spec for reference: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_linkedEditingRange
This PR against VS Code also stubs out this feature using the proposed API: microsoft/vscode#176279 Let me know once you have something on the TS side and I will update the VS Code PR to match the actual protocol
Reacted by Isabel Duan, qiqiboy and cachius- added 2 commits that reference this issue
on Mar 28, 2023 - added 2 commits that reference this issue
on Apr 10, 2023 I see this issue is closed, but it still doesn't work for me. Is JSX linked editing supported?
Buleandra Cristian (@Cristy94) be sure that
"editor.linkedEditing": trueis set onsettings.json. it's disabled by defaultReacted by Isabel Duan, Colin and José CageBuleandra Cristian (@Cristy94) be sure that
"editor.linkedEditing": trueis set onsettings.json. it's disabled by defaultAm I missing anything? Is there a shortcut for it? I didn't find any documentation for this feature.
If I just edit the opening tag of a<div></div>element, the end tag is not updated.
If I use CTRL+F2, all occurrences of"div"in that document are replaced.It seems to work for HTML (as expected, automatically edit, no keyboard shortcut needed). But for .jsx and .tsx it doesn't work or highlight the tags.
Found the issue, it doesn't work in TypeScript 5.0, and my editor was using the wrong version:
Reacted by Isabel Duan
microsoft/vscode#47069 implements this for HTML.
We should look for a way to support this for JSX/TSX.