Repository navigation
Add jsx linked editing - #176279
Merged
Merged
Add jsx linked editing#176279
Conversation
Matt Bierner (mjbvz)
changed the title
Matt Bierner (mjbvz)
force-pushed
the
grateful-fish
branch
2 times, most recently
from
April 3, 2023 18:23
47f9bcc to
cb90205
Compare
Matt Bierner (mjbvz)
force-pushed
the
grateful-fish
branch
from
April 10, 2023 17:15
cb90205 to
91b6311
Compare
Matt Bierner (mjbvz)
marked this pull request as ready for review
April 10, 2023 17:15
Matt Bierner (mjbvz)
enabled auto-merge (squash)
April 10, 2023 17:18
Logan Ramos (lramos15)
previously approved these changes
Apr 10, 2023
Matt Bierner (mjbvz)
changed the title
Peng Lyu (rebornix)
approved these changes
Apr 10, 2023
Daniel Rosenwasser (DanielRosenwasser)
left a comment
Daniel Rosenwasser (DanielRosenwasser)
left a comment
Member
There was a problem hiding this comment.
Probably fine as is, but I think I caught a minor issue using the semantic selector instead of the syntactic one.
| requireMinVersion(client, JsxLinkedEditingSupport.minVersion), | ||
| requireSomeCapability(client, ClientCapability.Syntax), | ||
| ], () => { | ||
| return vscode.languages.registerLinkedEditingRangeProvider(selector.semantic, |
There was a problem hiding this comment.
Should this be selector.syntax?
| import { ClientCapability, ITypeScriptServiceClient } from '../typescriptService'; | ||
| import { conditionalRegistration, requireMinVersion, requireSomeCapability } from './util/dependentRegistration'; | ||
|
|
||
| class JsxLinkedEditingSupport implements vscode.LinkedEditingRangeProvider { |
There was a problem hiding this comment.
Nit - you currently don't limit this to any JSX-specific file, so maybe we rename this to LinkedEditingSupport and just leave a comment about the main use-case being JSX tags?
Contributor
Author
There was a problem hiding this comment.
Thanks. Will follow up with these changes in a new PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For microsoft/TypeScript#51832