Repository navigation
Invalid type definitions generated when imported classes have same name #55375
Description
🔎 Search Terms
type definitions invalid name
🕗 Version & Regression Information
- This is the behavior since TypeScript 4.0, worked in 3.9.10
⏯ Playground Link
https://github.com/MoonE/ts-types-bug
💻 Code
test/Test.js
/** @module test/Test */
class Test {}
export default Test;Test.js
/** @module Test */
class Test {}
export default Test;X.js
import Test from './test/Test.js'
/**
* @typedef {Object} Options
* @property {typeof import("./Test.js").default} [test]
*/
class X extends Test {
/**
* @param {Options} options
*/
constructor(options) {
super();
if (options.test) {
this.test = new options.test();
}
}
}
export default X;🙁 Actual behavior
In the generate file there is a reference to a wrong class name (Test_1)
X.d.ts
export default X;
export type Options = {
test?: typeof import("./Test.js").default | undefined;
};
/**
* @typedef {Object} Options
* @property {typeof import("./Test.js").default} [test]
*/
declare class X extends Test {
/**
* @param {Options} options
*/
constructor(options: Options);
test: import("./Test.js").default | undefined;
}
import Test_1 from './test/Test.js';
//# sourceMappingURL=X.d.ts.map🙂 Expected behavior
The class in the import statement should be named Test.
Activity
MoonE commentedon Aug 14, 2023
The original issue openlayers/openlayers#15014
MoonE commentedon Aug 14, 2023
This only happens when the test property of the Options object is optional
* @property {typeof import("./Test.js").default} [test]