Skip to content

Trim empty line whitespaces - #5154

Closed
Kagami Sascha Rosylight (saschanaz) wants to merge 1 commit into
microsoft:masterfrom
saschanaz:master
Closed

Kagami Sascha Rosylight (saschanaz) wants to merge 1 commit into
microsoft:masterfrom
saschanaz:master

Conversation

@saschanaz

Copy link
Copy Markdown
Contributor

Fixes #4984

  • Fix duplication
  • Add tests

@saschanaz

Copy link
Copy Markdown
Contributor Author

Runs well on Visual Studio but keeps failing on tests with "destroyed non-whitespace content". I have no idea. Hmm.

@RyanCavanaugh

Copy link
Copy Markdown
Member

keeps failing on tests with "destroyed non-whitespace content"

This is an assertion in the fourslash harness that ensures our formatting edits only ever remove whitespace (we kept having bugs where you'd format e.g. var foo = 3; and get something bad like var fo = 3;).

@saschanaz

Copy link
Copy Markdown
Contributor Author

Ryan Cavanaugh (@RyanCavanaugh) Yes, I understand what the test does but I have no idea why the results in test set and Visual Studio are different. Copy-pasting the failing test on VS shows no bug.

Never mind, it was because duplicated deletion requests.

@DanielRosenwasser

Copy link
Copy Markdown
Member

👍

@DanielRosenwasser

Copy link
Copy Markdown
Member

Vladimir Matveev (@vladima) can you take a look when you get the chance?

@saschanaz

Copy link
Copy Markdown
Contributor Author

Replaced by #5983.

@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants