Repository navigation
Stop destructuring private properties - #7262
Merged
Nathan Shively-Sanders (sandersn) merged 4 commits intoFeb 26, 2016
Merged
Nathan Shively-Sanders (sandersn) merged 4 commits into
Nathan Shively-Sanders (sandersn) merged 4 commits into
Conversation
This is probably the wrong place (a get- function rather than a check- function), but it's a starting point since it passes all tests.
| } | ||
|
|
||
| const property = getPropertyOfType(parentType, text); | ||
| if (parent && parent.initializer && property && getParentOfSymbol(property)) { |
There was a problem hiding this comment.
parent should always be defined for a binding pattern.
There was a problem hiding this comment.
Why do you need getParentOfSymbol?
Member
Author
There was a problem hiding this comment.
checkClassPropertyAccess needs it, but sometimes it's undefined.
Member
Author
There was a problem hiding this comment.
removed the check
Member
|
👍 |
Nathan Shively-Sanders (sandersn)
added a commit
that referenced
this pull request
Feb 26, 2016
…operties Stop destructuring private properties
Nathan Shively-Sanders (sandersn)
deleted the
stop-destructuring-private-properties
branch
February 26, 2016 23:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7124
It does this by calling
checkClassPropertyAccessfromgetTypeFromBindingElement. I don't think this is a good idea, so I'm going to go look whether I can call it fromcheckVariableLikeDeclarationor something similar.The third commit changes
checkClassPropertyAccessto tighten the error span. You should review the 3 commits separately.Update: Now it's called from
checkVariableLikeDeclarationinstead.