Refactoring node code into nodeclient module - #2

VERY VERY minor stuff : python style uses underscore instead of camel case. I do not if we want to follow Python style guide closely. I just raise this now since we are moving things around

Great to see some modularity. OK with me to remove all print statements. Was planning to go_to_snake_case. I figured out after I started with camel case that Sublime Text was normalizing to snake case and that python often uses that convention.

Am wondering what would happen if we placed listener class in separate file (would somehow need to get at the singleton client instance). It's about half the code.
👍

I referred to this for coding guidelines: https://www.python.org/dev/peps/pep-0008/ I don’t see one recommended naming standard. They definitely use different naming standards in the Python library. I just would like us to stay consistent. Here is my preference:

• I prefer camel casing
• Pascal casing for classes
• all lowercase for modules
• constants are UPPER_CASE

I will look into the listener when I do my other proxy change.

From: Steve Lucco [mailto:[email protected]]
Sent: Wednesday, February 4, 2015 9:31 PM
To: Microsoft/TypeScript-Service
Cc: Hani Atassi
Subject: Re: [TypeScript-Service] Refactoring node code into nodeclient module (#2)

Great to see some modularity. OK with me to remove all print statements. Was planning to go_to_snake_case. I figured out after I started with camel case that Sublime Text was normalizing to snake case and that python often uses that convention.

Am wondering what would happen if we placed listener class in separate file (would somehow need to get at the singleton client instance). It's about half the code.
[:+1:]

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-72996639.

Hani Atassi (@hinzo) I see. I agree with you on consistency. I have no strong preference on naming standard so if that is what you prefer, I will be happy to adopted into the vim-client and use the similar style.

To clarify, there is a section for naming conventions:

Prescriptive: Naming Conventions

Function Names

Function names should be lowercase, with words separated by underscores as necessary to improve readability.

Method Names and Instance Variables

Use the function naming rules: lowercase with words separated by underscores as necessary to improve readability.

Constants

Constants are usually defined on a module level and written in all capital letters with underscores separating words. Examples include MAX_OVERFLOW and TOTAL

Though I agree, I prefer camel casing.

Camel ok with me. Note sublime will turn camel into snake in for example view.run_command. Also Sublime has conventions such as command classes end in 'command' but this is dropped in command name used for menus and run_command

Sent from my Windows Phone

From: Yuimailto:[email protected]
Sent: ý2/ý5/ý2015 12:02 PM
To: Microsoft/TypeScript-Servicemailto:[email protected]
Cc: Steve Luccomailto:[email protected]
Subject: Re: [TypeScript-Service] Refactoring node code into nodeclient module (#2)

@hinzohttps://github.com/hinzo I see. I agree with you on consistency. I have no strong preference on naming standard so if that is what you prefer, I will be happy to adopted into the vim-client and use the similar style.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-73115973.