This repository was archived by the owner on Dec 7, 2021. It is now read-only.
Repository navigation
feat: CNTK Export Provider - #771
Merged
Merged
Conversation
Wallace Breza (wbreza)
requested review from
Jacopo Mangiavacchi (JacopoMangiavacchi) and
Phil (PIC123)
April 17, 2019 21:19
Tanner Barlow (tbarlow12)
approved these changes
Apr 17, 2019
| }, | ||
| }, | ||
| testTrainSplit: { | ||
| title: "Prueba/tren Split", |
Contributor
There was a problem hiding this comment.
La división para entrenar y comprobar
| }, | ||
| testTrainSplit: { | ||
| title: "Prueba/tren Split", | ||
| description: "La división del tren de prueba que se utilizará para los datos exportados", |
Contributor
There was a problem hiding this comment.
La división de datos para utilizar entre el entrenamiento y la comprobación
Jacopo Mangiavacchi (JacopoMangiavacchi)
approved these changes
Apr 17, 2019
Jacopo Mangiavacchi (JacopoMangiavacchi)
left a comment
Jacopo Mangiavacchi (JacopoMangiavacchi)
left a comment
Contributor
There was a problem hiding this comment.
lgtm but haven't found time to test the output yet
Collaborator
|
Yeah looks good - like Jacopo, I was wondering if anyone had tried using the output w/ CNTK or on the DSVM. |
P.J. Little (pjlittle)
approved these changes
Apr 17, 2019
Contributor
Author
|
Jacopo Mangiavacchi (@JacopoMangiavacchi) P.J. Little (@pjlittle) - I didn't load up the data into any ML pipeline / tool, but compared the output from a project in v1 vs v2 and is the same. I'll complete the merge for now but will also attempt to load training data into some model. |
Wallace Breza (wbreza)
added a commit
that referenced
this pull request
Apr 29, 2019
Adds CNTK export provider into v2 Resolves #754
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds CNTK export provider into v2
Resolves #754