This repository was archived by the owner on Dec 7, 2021. It is now read-only.
Repository navigation
feat: move asset preview to horizontal - #870
Merged
Elizabeth Halper (elizabethhalper) merged 5 commits intoAug 22, 2019
Merged
Conversation
Collaborator
|
Just one comment, otherwise good. Glad to see this get merged! |
P.J. Little (pjlittle)
previously approved these changes
Aug 22, 2019
Tanner Barlow (tbarlow12)
previously approved these changes
Aug 22, 2019
Tanner Barlow (tbarlow12)
left a comment
Tanner Barlow (tbarlow12)
left a comment
Contributor
There was a problem hiding this comment.
Just PJ's comment, otherwise looks great 👍
Elizabeth Halper (elizabethhalper)
dismissed stale reviews from Tanner Barlow (tbarlow12) and P.J. Little (pjlittle)
via
August 22, 2019 17:44
c391ac9
Tanner Barlow (tbarlow12)
self-requested a review
August 22, 2019 17:49
My (mydiemho)
approved these changes
Aug 22, 2019
|
|
||
| private rowRenderer = ({ key, index, style }): JSX.Element => { | ||
| const asset = this.props.assets[index]; | ||
| private rowRenderer = ({ columnIndex, key, style }): JSX.Element => { |
Contributor
There was a problem hiding this comment.
switching index and key location on purpose?
Tanner Barlow (tbarlow12)
added a commit
that referenced
this pull request
Aug 22, 2019
This reverts commit 5e25dc5.
Tanner Barlow (tbarlow12)
added a commit
that referenced
this pull request
Aug 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: change sidebar from vertical to horizontal
Moved the vertical asset previewer to be horizontal and at the bottom of the screen. This helps maximize the size of the picture being tagged when it is a landscape photo.
AB#860