Repository navigation
Fix VS builds by just doing a direct include of TestBase - #2173
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused project-file changes resolve the missing solution dependency without introducing unresolved issues.
Review effort: Balanced
Findings: None
What changed in this PR
Removes unavailable Tsavorite test-project dependencies from Visual Studio builds while retaining shared TestBase functionality.
Changes:
- Remove references to
Tsavorite.test.csproj. - Compile the shared
TestBase.csdirectly into both test projects.
| File | Description |
|---|---|
test/standalone/Garnet.test/Garnet.test.csproj |
Directly includes the shared test base. |
test/cluster/Garnet.test.cluster/Garnet.test.cluster.csproj |
Directly includes the shared test base. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Vasileios Zois (vazois)
approved these changes
Sep 25, 2026
Ted Hart (TedHartMS)
added a commit
that referenced
this pull request
Sep 27, 2026
Merges origin/main d2d71f6 (8 commits). Git reported zero textual conflicts; all 211 files auto-merged. One semantic break required a fix. Main's #2162 and #2173 moved TestBase from Garnet.test to Tsavorite.test (libs/storage/Tsavorite/cs/test/TestBase.cs) and removed the Garnet ProjectReference from the Tsavorite test projects. Seven test files added by this branch imported TestBase via "using Garnet.test;" and stopped compiling with CS0246. That line is removed from each; no replacement using is needed because all seven declare namespaces nested under Tsavorite.test, so TestBase now resolves by enclosing-namespace lookup. test.recovery/V7DownlevelRecoveryTests.cs test.recovery/LogGeometryVerificationTests.cs test.recovery/ObjectRecoveryUndoReflushTests.cs test.recovery/ObjectSizeBoundaryDiskIOTests.cs test.recovery/ObjectSizeBoundaryRecoveryTests.cs test.recovery/SnapshotBoundarySectorTests.cs test.recordops/ObjectReadOnlyFlushTraceTests.cs Note that dotnet build Garnet.slnx reports 0 warnings and 0 errors while this break is present, because Garnet.slnx does not contain the Tsavorite test projects. Verifying a merge requires building both solutions. This merge also brings in 917e0e1 (#2172), which fixes checkpoint abort abandoning in-flight flushes. Verified: build 0 warnings / 0 errors on both solutions; dotnet format --verify-no-changes clean on both; Tsavorite.test.recovery 575 passed; Tsavorite.test.recordops 379 passed; CheckpointFailureTests 10 passed.
x@01 (x-at-01)
added a commit
to webc-fork/garnet
that referenced
this pull request
Oct 4, 2026
…lude TestBase directly for VS builds (microsoft#2173)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds in VS break because it doesn't know about Tsavorite.test in the SLNX.
Just directly include TestBase - less robust, but works.