Repository navigation
Fix CommandInfoUpdater - #2183
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused configuration change correctly addresses the parser’s explicit RESP2 assumptions.
Review effort: Balanced
Findings: None
What changed in this PR
Forces RESP2 when querying command documentation, matching the parser’s expected response structure.
Changes:
- Configures StackExchange.Redis to use RESP2.
- Documents the parser’s protocol dependency.
| File | Description |
|---|---|
playground/CommandInfoUpdater/CommandDocsUpdater.cs |
Sets RESP2 for command documentation queries. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Badrish Chandramouli (badrishc)
approved these changes
Sep 29, 2026
x@01 (x-at-01)
added a commit
to webc-fork/garnet
that referenced
this pull request
Oct 4, 2026
…2 for parsing connection (microsoft#2183)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parts of this code assume RESP2, which is no longer the default in SE.Redis. Simple fix to force a particular protocol.