Repository navigation
Fix Vector Set RESP2 and RESP3 reply contracts - #2184
Merged
Tiago Nápoli (tiagonapoli) merged 8 commits intoSep 30, 2026
Merged
Tiago Nápoli (tiagonapoli) merged 8 commits into
Tiago Nápoli (tiagonapoli) merged 8 commits into
Conversation
Cover all twelve Vector Set commands under both protocols and correct VREM boolean, VSIM missing-attribute, and VINFO metadata replies. Test and document the existing VLINKS protocol types without changing its native neighbor grouping. Co-authored-by: Copilot <[email protected]> Copilot-Session: 8f3348cd-0095-4ac5-ad48-7ee7f210131b
Copilot started reviewing on behalf of
Tiago Nápoli (tiagonapoli)
September 29, 2026 17:21
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
VINFO tests verify only one of the five numeric fields whose wire types changed.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Corrects Vector Set RESP2/RESP3 reply contracts and adds protocol coverage.
Changes:
- Fixes VREM, VINFO, and missing VSIM attribute replies.
- Adds 32 RESP protocol test cases.
- Updates VREM and VINFO documentation.
| File | Description |
|---|---|
libs/server/Resp/RespServerSessionOutput.cs |
Adds protocol-aware boolean output. |
libs/server/Resp/Vector/RespServerSessionVectors.cs |
Corrects Vector Set reply encoding. |
test/standalone/Garnet.test.vectorset/VectorSetProtocolTests.cs |
Adds RESP2/RESP3 contract tests. |
website/docs/commands/vector-sets.md |
Documents corrected replies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <[email protected]> Copilot-Session: 8f3348cd-0095-4ac5-ad48-7ee7f210131b
kevin-montrose
requested changes
Sep 29, 2026
kevin-montrose
left a comment
kevin-montrose
left a comment
Contributor
There was a problem hiding this comment.
Looks like some of the existing VSIM tests need to be updated?
added 2 commits
September 29, 2026 14:14
Co-authored-by: Copilot <[email protected]> Copilot-Session: 8f3348cd-0095-4ac5-ad48-7ee7f210131b
Co-authored-by: Copilot <[email protected]> Copilot-Session: 8f3348cd-0095-4ac5-ad48-7ee7f210131b
kevin-montrose
approved these changes
Sep 29, 2026
x@01 (x-at-01)
added a commit
to webc-fork/garnet
that referenced
this pull request
Oct 4, 2026
…2187,microsoft#2188,microsoft#2189), Vector Sets expiration after migration (microsoft#2179), Vector Set RESP2/RESP3 contracts (microsoft#2184), AOF recovery hang + ScanCursor read-ahead + size-tracker fixes (microsoft#2181)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WITHATTRIBSattribute when absent.