Skip to content

Limited native window tabs functionality in macOS high sierra #35361

Closed
Closed
Limited native window tabs functionality in macOS high sierra#35361
Assignees
bpasero
Labels
bugIssue identified by VS Code Team member as probable bugmacosIssues with VS Code on MAC/OS XupstreamIssue identified as 'upstream' component related (exists outside of VS Code)verifiedVerification succeededworkbench-os-integrationNative OS integration issues
Milestone
June 2018

Description

@ddotlic
Drazen Dotlic (ddotlic)
opened on Sep 29, 2017
  • VSCode Version: Code - Insiders 1.17.0-insider (f7962f0, 2017-09-20T05:10:59.524Z)
  • OS Version: Darwin x64 17.0.0
  • Extensions: (unimportant, see below)

Steps to Reproduce:

  1. Try to use "window.nativeTabs": true option, notice the squiggles and message says Unknown configuration setting
  2. If you remove the setting, opening a new window does create a new window
  3. If you put the setting back, it is respected, but creating a new window creates (visually) empty native tab bar (previously it showed two tabs, as expected); clicking on the tab creates a new window, as if the whole tab bar is in fact the newly added (looking at 1.17 release notes) "+" button to add a new window/tab
  4. Switching windows works, my custom shortcuts are respected etc. all is well, except tabs display

One more thing 😉 bizarrely my insider hasn't been updates since 20th of September (never seen insider go for 10 days without update). Downloading insider from Code's site also yields 20th of Sep version.

Reproduces without extensions: YES (as expected)

Activity

  1. vscodebot
    assigned
    Sandeep Somavarapu (sandy081)
    on Sep 29, 2017
  2. vscodebot
    added
    workbench
    on Sep 29, 2017
  3. Sandeep Somavarapu (sandy081)
    assigned
    Benjamin Pasero (bpasero)
    and unassigned
    Sandeep Somavarapu (sandy081)
    on Sep 29, 2017

  4. bpasero commented on Sep 29, 2017

    @bpasero
    Benjamin Pasero (bpasero)
    on Sep 29, 2017
    Contributor

    Drazen Dotlic (@ddotlic) but you are seeing the native tab bar to the top of the window?

    image

  5. Benjamin Pasero (bpasero)
    added
    info-neededIssue requires more information from poster
    on Sep 29, 2017
  6. Benjamin Pasero (bpasero)
    added this to the Backlog milestone on Sep 29, 2017
  7. Benjamin Pasero (bpasero)
    added a commit that references this issue on Sep 29, 2017

    fix bad macOS version check (for #35361)

    e97a3c6

  8. ddotlic commented on Sep 29, 2017

    @ddotlic
    Drazen Dotlic (ddotlic)
    on Sep 29, 2017
    ContributorAuthor

    Sorry, I'll post a screenshot now, it might be clearer (or not, you'll see):
    screen shot 2017-09-29 at 10 25 35

    The whole "tab" area behaves like a "+" button in your screenshot.

  9. ddotlic commented on Sep 29, 2017

    @ddotlic
    Drazen Dotlic (ddotlic)
    on Sep 29, 2017
    ContributorAuthor

    Needless to say, this worked fine yesterday (before I installed High Sierra update), this is a MacBook Pro 2015, always up to date so I expect no issues with drivers etc.

    If I can do something else to help (provide more info by running with particular command line switches) please do not hesitate to ask.

  10. Benjamin Pasero (bpasero)
    changed the title [-]Native tabs seem broken on High Sierra, using latest (yet stale) insider[/-] [+]Limited native window tabs functionality in macOS high sierra[/+] on Sep 29, 2017

  11. bpasero commented on Sep 29, 2017

    @bpasero
    Benjamin Pasero (bpasero)
    on Sep 29, 2017
    Contributor

    Unfortunately this looks like an issue in Elecron, I filed: electron/electron#10657

    For now the functionality seems limited at best. I think all that is going wrong is the rendering of native tabs, but otherwise the tabs are there.

  12. Benjamin Pasero (bpasero)
    added
    electronIssues and items related to Electron
    upstreamIssue identified as 'upstream' component related (exists outside of VS Code)
    and removed
    info-neededIssue requires more information from poster
    on Sep 29, 2017

  13. 114 remaining items

  14. chrmarti commented on Jun 28, 2018

    @chrmarti
    Christof Marti (chrmarti)
    on Jun 28, 2018
    Collaborator

    Got some help from Benjamin Pasero (@bpasero). Everything works now, thanks! Marking verified.

  15. Christof Marti (chrmarti)
    closed this as completedon Jun 28, 2018
  16. Christof Marti (chrmarti)
    added
    verifiedVerification succeeded
    and removed
    verification-foundIssue verification failed
    on Jun 28, 2018

  17. fmunteanu commented on Jun 28, 2018

    @fmunteanu
    Floren Munteanu (fmunteanu)
    on Jun 28, 2018

    Christof Marti (@chrmarti) when do we have this fix pushed into stable release?

  18. chrmarti commented on Jun 28, 2018

    @chrmarti
    Christof Marti (chrmarti)
    on Jun 28, 2018
    Collaborator

    Floren Munteanu (@fmunteanu) With 1.25 some time next week.

  19. sebastianreloaded commented on Jul 6, 2018

    @sebastianreloaded
    Sebastian Opel (sebastianreloaded)
    on Jul 6, 2018

    for me it didn't work at first but after disabling nativeTabs and reenabling them through the new settings editor worked.

  20. pi0 commented on Jul 6, 2018

    @pi0
    Pooya Parsa (pi0)
    on Jul 6, 2018

    I can confirm it is working like a charm now :)

    MacOS: 10.13.4
    VSCode: 1.25.0-insider

    image

  21. deyhle commented on Jul 6, 2018

    @deyhle
    Ruben Deyhle (deyhle)
    on Jul 6, 2018

    Wait, so the native tabs are replacing the file tabs? I was under the impression that native tabs are (finally) a way to properly switch between multiple project windows, and that we have the file tabs rendered in VS Code below those for each project. So with native tabs we're also losing the grid layout editor functionality?

  22. chabou-san commented on Jul 6, 2018

    @chabou-san
    Damien C. (chabou-san)
    on Jul 6, 2018

    Ruben Deyhle (@deyhle) They are not replacing the file tabs, see my screenshots below :

    screen shot 2018-07-06 at 10 04 43

    It's behaving exactly as you'd have them to. I could have show you the grid layout functionality too, it's just that I didn't in my screenshot. But I can confirm it's also working. ;)

  23. fmunteanu commented on Jul 6, 2018

    @fmunteanu
    Floren Munteanu (fmunteanu)
    on Jul 6, 2018

    Christof Marti (@chrmarti) I don't see the feature listed in 1.25 (stable just released), can you please confirm it is implemented? Thanks!

  24. scottohara commented on Jul 7, 2018

    @scottohara
    Scott O'Hara (scottohara)
    on Jul 7, 2018

    Floren Munteanu (@fmunteanu) As it's not a new feature (but rather a fix to an existing feature that broke in High Sierra), you'll find it under the "Notable Changes" and "Thank You" sections of the release notes.

    I can confirm that it is implemented and working in stable. 🎉

    release_notes__1_25_0_and_limited_native_window_tabs_functionality_in_macos_high_sierra_ issue__35361 _microsoft_vscode

    release_notes__1_25_0_ _confluence-open-api-connect

  25. RoarkeRandall commented on Jul 7, 2018

    @RoarkeRandall
    RoarkeRandall
    on Jul 7, 2018 via email

  26. pho3nixf1re commented on Jul 7, 2018

    @pho3nixf1re
    Matthew Turney (pho3nixf1re)
    on Jul 7, 2018 via email
  27. microsoft
    locked and limited conversation to collaborators on Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugmacosIssues with VS Code on MAC/OS XupstreamIssue identified as 'upstream' component related (exists outside of VS Code)verifiedVerification succeededworkbench-os-integrationNative OS integration issues

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions