Skip to content

Add gitignore language - #51026

Merged
Martin Aeschlimann (aeschli) merged 1 commit into
microsoft:masterfrom
Hirse:master
Jun 4, 2018
Merged

Martin Aeschlimann (aeschli) merged 1 commit into
microsoft:masterfrom
Hirse:master

Conversation

@Hirse

Copy link
Copy Markdown
Contributor

See microsoft/vscode-eslint#473
Martin Aeschlimann (@aeschli), Dirk Bäumer (@dbaeumer)
This only adds the Ignore-language and assigns it to .gitignore.
I would like to add a reference to it in extensions/npm for .npmignore. Is it possible to add that file association as contribution in the package.json or how would you propose to do it?

@aeschli

Martin Aeschlimann (aeschli) commented Jun 4, 2018 •

Copy link
Copy Markdown
Contributor

That looks good. I'd suggest to give it id gitignore even if it is now used in many other contexts.
I'll make that change...
Thinking more about it, 'ignore' is fine as id.

@aeschli
Martin Aeschlimann (aeschli) merged commit 439ac99 into microsoft:master Jun 4, 2018
@aeschli Martin Aeschlimann (aeschli) added this to the June 2018 milestone Jun 4, 2018
@aeschli

Copy link
Copy Markdown
Contributor

I added support for npmignore, see the change set.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants