Repository navigation
Support adding/deleting reviewers and labels - #955
Merged
Rachel Macfarlane (RMacfarlane) merged 6 commits intoFeb 22, 2019
Merged
Conversation
Rachel Macfarlane (RMacfarlane)
requested review from
Ashi Krishnan (queerviolet) and
Peng Lyu (rebornix)
February 15, 2019 21:14
Rachel Macfarlane (RMacfarlane)
changed the title
added 5 commits
February 22, 2019 09:59
Rachel Macfarlane (RMacfarlane)
force-pushed
the
rmacfarlane/add-reviewers
branch
from
February 22, 2019 18:02
481156a to
aad1abc
Compare
Contributor
|
Run into following issues
Quickpick related
|
|
|
||
| async addLabels(pullRequest: PullRequestModel, labels: string[]): Promise<void> { | ||
| const { octokit, remote } = await pullRequest.githubRepository.ensure(); | ||
| octokit.issues.addLabels({ |
Contributor
There was a problem hiding this comment.
do we want to await this call?
Contributor
Author
There was a problem hiding this comment.
yeah, nice catch
|
|
||
| async removeLabel(pullRequest: PullRequestModel, label: string): Promise<void> { | ||
| const { octokit, remote } = await pullRequest.githubRepository.ensure(); | ||
| octokit.issues.removeLabel({ |
Peng Lyu (rebornix)
suggested changes
Feb 22, 2019
Peng Lyu (rebornix)
left a comment
Peng Lyu (rebornix)
left a comment
Contributor
There was a problem hiding this comment.
LGTM in overall, the label filtering issue is probably what we want to fix before merge.
Contributor
Author
|
Fixed the label filtering problem, the quickpick issue seems to be a problem with the webview getting refocused, so I think it might be an upstream issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #951
#412
Adding uses the quickpick:
Icon to remove appears on hover when the view is shown as a sidebar:
When the window is less than 900px wide, content looks like, with delete icons always shown:
