Skip to content

Support non-zero exit codes as success #137

Closed

Description

Description of the new feature/enhancement

Some applications return non-zero codes that are not errors. There should be a way for the client to know the difference between these codes and actual errors.

Proposed technical implementation details (optional)

A key could be added to the manifest syntax to indicate which non-zero codes should be treated as success. The client could then treat these non-zero return codes as success.

Activity

  1. chausner commented on May 22, 2020

    @chausner
    Contributor

    This is the case with installers wrapped in a WinRAR self-extracting archive, for example (e.g. microsoft/winget-pkgs#535). RARSFX will return exit code 1000 if the installation succeeded, and any other code indicates an error.

  2. added this to the milestone on May 23, 2020
  3. superusercode commented on May 24, 2020

    @superusercode
    Contributor

    This also impacts adobe digital editions, and there are plenty more documented in installers listed on chocolatey/scoop https://chocolatey.org/packages/adobedigitaleditions#files.

  4. denelon commented on Jul 28, 2020

    @denelon
    CollaboratorAuthor
  5. denelon commented on Jul 28, 2020

    @denelon
    CollaboratorAuthor
  6. modified the milestones: , on Aug 24, 2020
  7. modified the milestones: , Package Manager v1.0 on May 3, 2021
  8. denelon commented on May 3, 2021

    @denelon
    CollaboratorAuthor

    This feature is complete with the v1.0 schema and the v0.3 client release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Issue-FeatureThis is a feature request for the Windows Package Manager client.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions