Repository navigation
Add Anvil Studio 2020.12.03 - #535
4 commits merged into
Conversation
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wingetbot (wingetbot)
added
the
Azure-Pipeline-Passed
|
This submission has moved to manual review. |
Kevin Larkin (MS) (KevinLaMS)
added
the
Validation-Installation-Error
|
chausner The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request. |
ghost
added
Needs: author feedback
and removed
Azure-Pipeline-Passed
|
Installer failed with exit code 1000 |
Yes, this is to be expected. See also the comment I added in the manifest file. The installer in this case is wrapped in a WinRAR self-extracting archive. After extracting, RARSFX runs the installer and returns with the installer exit code + 1000. That means, if the installer succeeded (exit code 0), RARSFX will return exit code 1000. We need a way to specify a success exit code in the manifest file, as not all applications on Windows adhere to 0 = success. |
Kevin Larkin (MS) (KevinLaMS)
added
the
Blocking-Issue
ghost
removed
Blocking-Issue
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wingetbot (wingetbot)
added
the
Azure-Pipeline-Passed
|
This submission has moved to manual review. |
ghost
removed
the
Azure-Pipeline-Passed
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wingetbot (wingetbot)
added
the
Azure-Pipeline-Passed
|
This submission has moved to manual review. |
|
Hello Kevin Larkin (MS) (@KevinLaMS)! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Deleted user (ghost)
left a comment
Deleted user (ghost)
left a comment
There was a problem hiding this comment.
Validation has completed
Due to certain bugs in yaml-cpp, it has not had significant fuzzing applied. Even if those bugs were fixed, it is unknown how many more might exist behind it. In order to avoid chasing those bugs, we are switching to a YAML parser that does have significant fuzz testing coverage, [libyaml](https://github.com/yaml/libyaml). In addition to the use of libyaml, a C++ wrapper is written to create a near identical surface area for use by the existing manifest validation. It also includes encoding detection to enable support for ANSI (assumed Windows-1252, which wasn't supported by yaml-cpp), UTF-8 (with and without BOM), UTF-16 LE/BE (both with and without BOM). Finally, the `validate` command now returns a non-zero value when there are issues. If there is a failure during validation, the value returned is `0x8A150029`. If there are only warnings, the value returned is `0x8A150028`.
4 participants
Microsoft Reviewers: Open in CodeFlow