Skip to content

Add cross-domain-saliency-maps package in related_software. - #13413

Merged
larsoner merged 3 commits into
mne-tools:mainfrom
christodouloskech:related-software-cross-domain-saliency-maps
Sep 11, 2025
Merged

larsoner merged 3 commits into
mne-tools:mainfrom
christodouloskech:related-software-cross-domain-saliency-maps

Conversation

@christodouloskech

Copy link
Copy Markdown
Contributor

What does this implement/fix?

Add cross-domain-saliency-maps python package to the related software.

@welcome

welcome Bot commented Sep 11, 2025

Copy link
Copy Markdown

Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴

@scott-huberty

Copy link
Copy Markdown
Contributor

Hey @christodouloskech

It looks to me like CircleCI wants to pre-install any "related software" packages that exist on PyPI, probably so that we can automatically extract the package description and display it on the website. e.g. you can see here that the build docs job executes circleci_dependencies.sh

So adding cross-domain-saliency-maps to this list in circles_dependencies.sh, should resolve the current doc build error.

alphaCSC autoreject bycycle conpy emd fooof meggie \
mne-ari mne-bids-pipeline mne-faster mne-features \
mne-icalabel mne-lsl mne-microstates mne-nirs mne-rsa \
neurodsp neurokit2 niseq nitime pactools mnelab \
plotly pycrostates pyprep pyriemann python-picard sesameeg \
sleepecg tensorpac yasa meegkit eeg_positions wfdb invertmeeg \
curryreader

@scott-huberty scott-huberty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.

@christodouloskech

Copy link
Copy Markdown
Contributor Author

I added cross-domain-saliency-maps in circlecei_dependences.sh. cross-domain-saliency-maps requires both pytorch and tensorflow. For ease I added the --no-deps flag in pip install, so that installation of tensorflow and pytorch is skipped.

@christodouloskech

Copy link
Copy Markdown
Contributor Author

test_plot_volume_source_estimates_on_vol_labels seems to fail the test. Should this be affected by this documentation-only PR?

@larsoner

Copy link
Copy Markdown
Member

Only CIs that matter here are style and CircleCI and those look good, as does this page

https://output.circle-artifacts.com/output/job/f9a9569f-6db7-4d84-8eb6-6e08b1305e03/artifacts/0/html/install/mne_tools_suite.html#related-software

Thanks @christodouloskech !

@larsoner
larsoner merged commit 9ee6e52 into mne-tools:main Sep 11, 2025
12 of 14 checks passed
@welcome

welcome Bot commented Sep 11, 2025

Copy link
Copy Markdown

🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪

sseth pushed a commit to xannnimal/mne-python that referenced this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants