Repository navigation
[2017-04][tests] Rework TypeBuilderTest SetUp/TearDown - #5061
Merged
Merged
Conversation
- Create a unique temporary directory for each test in TypeBuilderTest and delete it on TearDown. - Change tests to use tempDir instead of Path.GetTempPath () - Change IsSerializable () test to how it was 11 years ago and have it write to a file with a simple name (but now in a directory where noone else is writing) - Change FieldsWithSameName (), FieldsWithSameNameAndType () and MethodsWithSameNameAndSig () to use the default temp assembly (now in a unique tempDir) instead of using the CreateTempAssembly () - Remove CreateTempAssembly function. It is dead code.
Windows doesn't like deleting the file, and the original bug was a problem in SRE, not in the AssemblyBuilder.Save ()
lambdageek
added a commit
to lambdageek/xamarin-android
that referenced
this pull request
Jun 20, 2017
Pick up mono/mono#5061 which fixes TypeBuilderTest failures due to temp directory location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #5059 for
2017-04Create a unique temporary directory for each test in TypeBuilderTest and delete
it on TearDown.
Change tests to use tempDir instead of Path.GetTempPath ()
Change IsSerializable () test to how it was 11 years ago and have it write to a
file with a simple name (but now in a directory where noone else is writing)
Change FieldsWithSameName (), FieldsWithSameNameAndType () and
MethodsWithSameNameAndSig () to use the default temp assembly (now in a
unique tempDir) instead of using the CreateTempAssembly ()
Remove CreateTempAssembly function. It is dead code.