This repository was archived by the owner on Nov 9, 2017. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 9, 2017. It is now read-only.
Git GUI here doesn't work anymore #95
Description
Git4Win: 1.8.1.2-20130204 (self-compiled from 8905816)
WinXP (32bit)
When I right-click a folder in the windows explorer and select Git GUI here I get this error:
That error disappears if i change the corresponding registry entry to:
"d:\usr\Git\bin\wish.exe" "d:\usr\Git\libexec\git-core\git-gui" "--working-dir" "%L"
(%v replaced with %L)
The same is true for Git Bash here.
Metadata
Metadata
Assignees
Labels
No labels
Activity
sschuberth commentedon Feb 4, 2013
How comes you're using "%L" instead of e.g. "%1"? Do you have a list of valid place-holders and their meaning? "%v" seems to be supported as of Windows Vista only, and only to be valid for
Directory\Backgroundregistry entries.snaewe commentedon Feb 4, 2013
I guess "%1" is as valid.
The best reference I found is this one: http://superuser.com/a/473602
patthoyts commentedon Feb 5, 2013
Did this affect upgrades as well as fresh installs? I just confirmed this on a fresh XP install. I'm wondering if we should issue a new installer quite soon if this will affect all users who selected to use the registry based explorer menu items.
sschuberth commentedon Feb 5, 2013
Yes, I'm pretty sure this did affect upgrades as well. When doing a new installer soon, there are probably other issues I'd like to see fixed before, in particular #61. @patthoyts could you please reply to my comment there.
mikofski commentedon Feb 5, 2013
Just out of curiosity, anyone know why this only affected git-gui and not git bash here? The are both changed in commit 49f9d8b but I only have the XP x64 issue with git-gui not git bash here shell extension, even though the
git_shellexplorer extension registry entry also used%v, which is alleged to only work with >= vista not XP.Regardless, the fix works great! Thanks for catching that! I just went in and changed the git-gui explorer extension registry entries from
%vto%1and all is well!sschuberth commentedon Feb 6, 2013
"Git Bash Here" calls "Git Bash.vbs", which in turn creates a temporary shortcut file which has the "Start in" property set to the desired directory. If that directory is invalid (like the literal "%v"), it seems the current directory is taken. And Explorer sets the current directory to the one from which the shell extension was launched before actually launching it. That's why it worked for "Git Bash Here" but not for "Git GUI Here". Note that some Explorer replacements do not change the current directory when launching shell extensions, so relying on that is a bad idea.
sschuberth commentedon Mar 4, 2013
It's an XP issue in the sense that XP does not yet seem to support registry-based background directory handlers.
%vis not a Visual Basic variable (if that's what you mean by "vb") but a variable that's set by the shell (in most cases Windows Explorer). Please note that this fix is not yet part of any official installer, so you will still see this issue if you're just using the stock Git-1.8.1.2-preview20130201.exe.Groovounet commentedon Sep 5, 2013
Hi,
I need to use a recent version of Perl to get some code working.
So downloading the stock version won't work, so what do we need to get?
Thanks,
Christophe
sschuberth commentedon Sep 5, 2013
@Groovounet Did your comment go to the wrong issue? This issue is not about Perl.
Groovounet commentedon Sep 5, 2013
Oups! Sorry you are right.