Repository navigation
Use 32-bit cmd.exe to open .sh files even on 64-bit Windows to avoid crashes - #26
Conversation
|
Testing your code in Windows XP 32bit now. Please cleanup your commit message according to sschuberth's comments and we can apply it. |
|
Ah and of course the code as well... |
|
My test on Windows XP 32bit was successful. |
|
@hvoigt and @sschuberth I hope you can cherry pick the last commit cb1e46944eca118629763740759de57d1e3ed305 |
|
Cherry-picking just your second commit will not suffice as it depends on your first commit. Please squash these two commits into one (using "git rebase -i HEAD~2"). |
|
even tho I already pushed the changes, ok Sent via Hubroid |
|
Yes, as your branch in not merged yet it's fine to rebase and force-push it. |
use %WINDIR%\SysWOW64\cmd /C to run "sh.exe --login %1 %*"
use {syswow64} variable to determine which cmd to use
addresses issue msysgit#12
Signed-off-by: Mark Mikofski <[email protected]>
|
ok, I squashed the commits on my end, but what is going to happen to the pull request when I push? |
|
AFAIK this pull request will update automatically if you force-push your rebased branch, so there's no need to file a new pull request. |
|
it worked! |
Use 32-bit cmd.exe to open .sh files even on 64-bit Windows to avoid crashes
3 participants
use
%WINDIR%\SysWOW64\cmd /Cto run"bash.exe --login %1 %*"use
{syswow64}Inno setup variable to determine whichcmdversion to use (x64 or x86)tested on Windows XP x64 Edition, Version 2003, SP2
*
address issue #12 and msysgit/git issue #8