Repository navigation
Finally: new website - #11
Conversation
Also remove trailing spaces and extra new lines.
* Use https for GitHub links * Remove unneeded end tags * Move target attribute at the end
gw1web_thumb.png | Bin 12394 -> 5724 bytes gw2web_thumb.png | Bin 12514 -> 5748 bytes gw3web_thumb.png | Bin 17703 -> 7841 bytes
See README.md for more info.
* add missing vendor prefixed properties * use hex colors when possible * be more explicit with the background property * use proper gradients for all browsers * remove the unneeded img/header_bg.png * other minor improvements
It's far more feature-complete than reset.css.
Grunt is basically like GNU make for client-side Javascript. You need node (http://nodejs.org/) and then install Grunt via 'npm install -g grunt-cli' and install the required modules with 'npm install'. Signed-off-by: Johannes Schindelin <[email protected]>
No need to go to Google and fetch jQuery... Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
All those pixel-exact specifications were a clear tell-tale of overfitting to one specific dimension. Testament to this is how bad the page looked on mobile devices (in particular, the need to scroll right and see that the background is cut off at the window width). Start fixing this by using measurements relative to the font size. This is of course only step one. The next steps will follow in separate commits. This change was based on the experiences related in http://alistapart.com/article/responsive-web-design Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
This also sets the height to 'auto' rather than some hardcoded value. That way, we can hope to get a nice layout even when we override the width via css. Signed-off-by: Johannes Schindelin <[email protected]>
|
Note: somehow I managed to revert the fixes for real small screens (240x380, my not-so-smart phone). Working on it. |
|
Looks great to me! Thanks a lot for spending time on this! |
|
Two nits, though:
|
|
One more nit: Before the stylesheet is loaded, the heading briefly says "Gitfor Windows" instead of "Git for Windows". I'm guessing this is because of the markup |
|
The last two are issues that can be ironed out after pushing, though (if at all). |
Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
|
@kusma thanks for looking! The problems with the preview and the initial "Gitfor Windows" are most likely caused by the HTML preview (I do not see them when trying things locally). In related news, I am done with the small screen fixes for now. I do not claim that I am the best web designer or CSS expert, so things are still a bit hacky, but I guess I was the only person willing to get the job done, and so I did. Read: I'm ready to merge. |
|
@dscho When you're running locally, the latency should be so low you can't see it :P |
|
Yeah, I was leaving out the fact that I used a private server for testing because I cannot get #@$^&!@# Android to load web pages via USB from my computer. |
|
Looks quite good to me, thanks. The screenshot thumbnails are blurry here, too, but I guess that's again due to htmlpreview. I also have some minor nitpicks, but I'll just fix them myself / file PRs after @dscho has merged. |
|
Thanks, @sschuberth! @patthoyts I hope you don't mind that I already merge before you come around to comment, but I promise (and have a track record of living up to my promises) to address each and every concern you might have with it. |
4 participants
Hey @kusma, @patthoyts and @sschuberth... Could you have a look at http://htmlpreview.github.io/?https://github.com/dscho/msysgit.github.com/blob/master/index.html to see whether you like it?
Unless I hear objections, I will merge it...