Skip to content

fix: make lm:setup test pass - #5980

Merged
Skn0tt merged 1 commit into
mainfrom
fix-lm-test
Sep 5, 2023
Merged

Skn0tt merged 1 commit into
mainfrom
fix-lm-test

Conversation

@Skn0tt

@Skn0tt Skn0tt commented Sep 5, 2023

Copy link
Copy Markdown
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Follow-up to #5975. It broke the lm:setup test, which is currently blocking main. Unsure why it didn't break in the PR's test run 🤔


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@Skn0tt
Skn0tt requested a review from mraerino September 5, 2023 13:18
@Skn0tt Skn0tt self-assigned this Sep 5, 2023
@Skn0tt
Skn0tt requested a review from a team as a code owner September 5, 2023 13:18
@Skn0tt
Skn0tt enabled auto-merge (squash) September 5, 2023 13:20
@github-actions

github-actions Bot commented Sep 5, 2023

Copy link
Copy Markdown

📊 Benchmark results

Comparing with 6afe7bd

  • Dependency count: 1,331 (no change)
  • Package size: 295 MB ⬆️ 0.00% increase vs. 6afe7bd

@Skn0tt
Skn0tt merged commit 40b3e78 into main Sep 5, 2023
@Skn0tt
Skn0tt deleted the fix-lm-test branch September 5, 2023 13:32
ChrisW-B added a commit to ChrisW-B/PersonalApi that referenced this pull request Sep 10, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`6.5.0` -> `6.6.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/6.5.0/6.6.0) |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`6.5.0` -> `6.6.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/6.5.0/6.6.0) |
| [@typescript-eslint/typescript-estree](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`6.5.0` -> `6.6.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2ftypescript-estree/6.5.0/6.6.0) |
| [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.48.0` -> `8.49.0`](https://renovatebot.com/diffs/npm/eslint/8.48.0/8.49.0) |
| [netlify-cli](https://github.com/netlify/cli) | devDependencies | minor | [`16.2.0` -> `16.3.1`](https://renovatebot.com/diffs/npm/netlify-cli/16.2.0/16.3.1) |

---

### Release Notes

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>

### [`v6.6.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#660-2023-09-04)

[Compare Source](typescript-eslint/typescript-eslint@v6.5.0...v6.6.0)

##### Bug Fixes

-   **eslint-plugin:** \[key-spacing] consider properties with parens and comments ([#&#8203;7525](typescript-eslint/typescript-eslint#7525)) ([7012279](typescript-eslint/typescript-eslint@7012279))

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

</details>

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>

### [`v6.6.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#660-2023-09-04)

[Compare Source](typescript-eslint/typescript-eslint@v6.5.0...v6.6.0)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

</details>

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/typescript-estree)</summary>

### [`v6.6.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/typescript-estree/CHANGELOG.md#660-2023-09-04)

[Compare Source](typescript-eslint/typescript-eslint@v6.5.0...v6.6.0)

**Note:** Version bump only for package [@&#8203;typescript-eslint/typescript-estree](https://github.com/typescript-eslint/typescript-estree)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

</details>

<details>
<summary>eslint/eslint (eslint)</summary>

### [`v8.49.0`](https://github.com/eslint/eslint/releases/tag/v8.49.0)

[Compare Source](eslint/eslint@v8.48.0...v8.49.0)

#### Features

-   [`da09f4e`](eslint/eslint@da09f4e) feat: Implement onUnreachableCodePathStart/End ([#&#8203;17511](eslint/eslint#17511)) (Nicholas C. Zakas)
-   [`32b2327`](eslint/eslint@32b2327) feat: Emit deprecation warnings in RuleTester ([#&#8203;17527](eslint/eslint#17527)) (Nicholas C. Zakas)
-   [`acb7df3`](eslint/eslint@acb7df3) feat: add new `enforce` option to `lines-between-class-members` ([#&#8203;17462](eslint/eslint#17462)) (Nitin Kumar)

#### Documentation

-   [`ecfb54f`](eslint/eslint@ecfb54f) docs: Update README (GitHub Actions Bot)
-   [`de86b3b`](eslint/eslint@de86b3b) docs: update `no-promise-executor-return` examples ([#&#8203;17529](eslint/eslint#17529)) (Nitin Kumar)
-   [`032c4b1`](eslint/eslint@032c4b1) docs: add typescript template ([#&#8203;17500](eslint/eslint#17500)) (James)
-   [`cd7da5c`](eslint/eslint@cd7da5c) docs: Update README (GitHub Actions Bot)

#### Chores

-   [`b7621c3`](eslint/eslint@b7621c3) chore: remove browser test from `npm test` ([#&#8203;17550](eslint/eslint#17550)) (Milos Djermanovic)
-   [`cac45d0`](eslint/eslint@cac45d0) chore: upgrade [@&#8203;eslint/js](https://github.com/eslint/js)[@&#8203;8](https://github.com/8).49.0 ([#&#8203;17549](eslint/eslint#17549)) (Milos Djermanovic)
-   [`cd39508`](eslint/eslint@cd39508) chore: package.json update for [@&#8203;eslint/js](https://github.com/eslint/js) release (ESLint Jenkins)
-   [`203a971`](eslint/eslint@203a971) ci: bump actions/checkout from 3 to 4 ([#&#8203;17530](eslint/eslint#17530)) (dependabot\[bot])
-   [`a40fa50`](eslint/eslint@a40fa50) chore: use eslint-plugin-jsdoc's flat config ([#&#8203;17516](eslint/eslint#17516)) (Milos Djermanovic)
-   [`926a286`](eslint/eslint@926a286) test: replace Karma with Webdriver.IO ([#&#8203;17126](eslint/eslint#17126)) (Christian Bromann)
-   [`f591d2c`](eslint/eslint@f591d2c) chore: Upgrade config-array ([#&#8203;17512](eslint/eslint#17512)) (Nicholas C. Zakas)

</details>

<details>
<summary>netlify/cli (netlify-cli)</summary>

### [`v16.3.1`](https://github.com/netlify/cli/blob/HEAD/CHANGELOG.md#1631-2023-09-06)

[Compare Source](netlify/cli@v16.3.0...v16.3.1)

##### Bug Fixes

-   **deps:** update dependency [@&#8203;netlify/build](https://github.com/netlify/build) to v29.20.13 ([#&#8203;5981](netlify/cli#5981)) ([d9545fa](netlify/cli@d9545fa))
-   **deps:** update dependency [@&#8203;netlify/edge-bundler](https://github.com/netlify/edge-bundler) to v8.19.1 ([#&#8203;5983](netlify/cli#5983)) ([9d86237](netlify/cli@9d86237))

### [`v16.3.0`](https://github.com/netlify/cli/blob/HEAD/CHANGELOG.md#1630-2023-09-06)

[Compare Source](netlify/cli@v16.2.0...v16.3.0)

##### Features

-   support `context.params` + `config.method` in functions + edge functions ([#&#8203;5970](netlify/cli#5970)) ([6afe7bd](netlify/cli@6afe7bd))

##### Bug Fixes

-   **deps:** update netlify packages ([#&#8203;5972](netlify/cli#5972)) ([34e0faa](netlify/cli@34e0faa))
-   **deps:** update netlify packages ([#&#8203;5974](netlify/cli#5974)) ([4a7d9df](netlify/cli@4a7d9df))
-   make lm:setup test pass ([#&#8203;5980](netlify/cli#5980)) ([40b3e78](netlify/cli@40b3e78))
-   show proper `req.url` in HTTPS mode ([#&#8203;5968](netlify/cli#5968)) ([da723a1](netlify/cli@da723a1))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 3pm on Sunday" in timezone America/New_York, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi43Ny4wIiwidXBkYXRlZEluVmVyIjoiMzYuNzcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: chris b <[email protected]>
Reviewed-on: https://git.chriswb.dev/chrisw-b/PersonalApi/pulls/6
Co-authored-by: Renovate Bot <[email protected]>
Co-committed-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants