Move magic numbers in layout files to @dims #12

Activity

1. AndyScherzinger

   added

   enhancement

   good first issue

   approved

   low

   hacktoberfest

   on Sep 28, 2016
3. AndyScherzinger commented on Oct 3, 2016

   

   AndyScherzinger

   on Oct 3, 2016

   MemberAuthor

   More actions

   Hi @sangeethaKP, absolutely yes! We would be happy about that contribution :)
   Any questions, please let me and @tobiasKaminsky know.
4. divayprakash

   added 8 commits that reference this issue on Oct 6, 2016

   Fix magic numbers in account_action.xml nextcloud#12

   1da94ff

   Fix magic numbers in account_item.xml nextcloud#12

   e7114a2

   Fix magic numbers in account_setup.xml nextcloud#12

   4bd89dc

   Fix magic numbers in land/account_setup.xml nextcloud#12

   faca8ff

   Fix magic numbers in account_layout.xml nextcloud#12

   824bf88

   Fix magic numbers in action_item.xml nextcloud#12

   adf1def

   Update @Dimen in action_item.xml nextcloud#12

   4ce8c61

   Update @Dimen in activity_row.xml nextcloud#12

   a772bee
5. 33 remaining items

   Load more
6. divayprakash

   added 9 commits that reference this issue on Oct 7, 2016

   Fix magic numbers in simple_dialog_list_item.xml nextcloud#12

   2a782e7

   Fix magic numbers in ssl_untrusted_cert_layout.xml nextcloud#12

   544aa39

   Fix magic numbers in ssl_validator_layout.xml nextcloud#12

   0564e69

   Fix magic numbers in toolbar_standard.xml nextcloud#12

   c02383b

   Fix magic numbers in upload_files_layout.xml nextcloud#12

   918bdd5

   Fix magic numbers in upload_list_group.xml nextcloud#12

   a3ddb28

   Fix magic numbers in upload_list_item.xml nextcloud#12

   d736536

   Fix magic numbers in upload_list_layout.xml nextcloud#12

   db3f069

   Fix magic numbers in uploader_list_item_layout.xml nextcloud#12

   f48b0b0
7. divayprakash commented on Oct 7, 2016

   

   divayprakash

   on Oct 7, 2016

   Member

   More actions

   @AndyScherzinger @tobiasKaminsky #12 is done!
8. divayprakash

   added 2 commits that reference this issue on Oct 7, 2016

   Fix errors with float values nextcloud#12

   cbbea08

   Fix error in share_file_layout_text_size value nextcloud#12

   2135b13
9. AndyScherzinger

   added this to the Nextcloud App 1.4.0 milestone on Oct 9, 2016
10. AndyScherzinger commented on Oct 9, 2016

    

    AndyScherzinger

    on Oct 9, 2016

    MemberAuthor

    More actions

    Merged! 🚀
    Again, Thanks for your contribution @divayprakash ! 👍
11. AndyScherzinger

    closed this as completedon Oct 9, 2016