request media_location by tobiasKaminsky · Pull Request #14247 · nextcloud/android

tobiasKaminsky · 2024-12-27T07:20:01Z

Tests written, or not not needed

BluePixel4k · 2025-01-01T12:30:12Z

#14135 (comment) - Quote with my answer/question:

Thus I created a draft PR, with an APK, that you can install in parallel: #14247 (comment)
@BluePixel4k can you test this?

Thanks a lot! Yes, it's working fine for me with this version 👍 But is it possible to enable the ACCESS_MEDIA_LOCATION already before the user grants the image and video permission? Because if a user doesn't grant the permission but shares a picture via his local gallery app to the Nextcloud app, the GPS information is missing.

Is this possible?

hw-hass23 · 2025-01-02T22:08:47Z

#14135 (comment) - Quote with my answer/question:

Thus I created a draft PR, with an APK, that you can install in parallel: #14247 (comment)
@BluePixel4k can you test this?

Thanks a lot! Yes, it's working fine for me with this version 👍 But is it possible to enable the ACCESS_MEDIA_LOCATION already before the user grants the image and video permission? Because if a user doesn't grant the permission but shares a picture via his local gallery app to the Nextcloud app, the GPS information is missing.

Is this possible?

Some gallery apps themselves have settings for "safe sharing" which zeros the GPS information upon sharing. Xiaomi Poco gallery is one of them (needed to disable "share without location" for proper sharing to Nextcloud app), whereas Google Foto left GPS intact.

tobiasKaminsky · 2025-01-09T06:23:55Z

/backport to stable-3.30

tobiasKaminsky · 2025-01-09T08:36:19Z

If no custom upload folder is found:

If custom upload folder is found:

Whisprin · 2025-01-09T15:24:10Z

thanks @tobiasKaminsky
Do you intend to send a notification to users after the upgrade? In order to satisfy #14349: Inform users who don't open the app regularly and rely on automatic background backups.

In case any (not just a custom) auto upload folder pair is found: Users should be informed explicitly that past Auto uploads didn't run since 3.30.6 (probably some time in mid December) and future Auto uploads won't run unless the new permission is granted.
It can also be made more explicit that Auto uploads of files other than photos and videos remain broken, even after granting the new permissions.
I'll post a revised draft of this message here later.

Is there way or a plan to ensure that those missed Auto uploads are carried out after the Photo and video permission is granted?
In my tests those past, missed uploads are not picked up automatically after the permission is granted.

Whisprin · 2025-01-09T16:04:13Z

How about:

Re-enable Disrupted Auto Uploads

Please check manually for missing file uploads since mid-December.
To re-enable Auto Uploads for new photos and videos:

Grant "Photos and Videos" permission in the next dialog,
Grant "Location" permission to keep location data in uploaded photos.

To re-enable Auto Uploads for all other files:

Auto Uploads of other files are not possible anymore with the Play Store version of the Nextcloud app.

Auto Uploads stopped working because Google rejected the necessary file permission in a previous app update. Nextcloud is working with Google to rectify the situation and restore full functionality.

alperozturk96 · 2025-01-13T12:56:50Z

@tobiasKaminsky I am unable to view the storage and notification permissions. Only the Google Play warnings are appearing. Also, Codacy Static Code Analysis fails.

tobiasKaminsky

+        viewThemeUtils.androidx.themeNotificationCompatBuilder(context, notificationBuilder)
+
+        val notificationManager = context.getSystemService(Context.NOTIFICATION_SERVICE) as NotificationManager
+        notificationManager.notify(notificationId, notificationBuilder.build())


To fix the problem, we need to ensure that the Intent used to create the PendingIntent is explicit. This can be done by setting the component name explicitly in the Intent. Additionally, we should verify that all other PendingIntent creations in the code follow the same practice.

Modify the Intent on line 210 to explicitly set the component name.

Ensure that the PendingIntent is created with the FLAG_IMMUTABLE flag to prevent modification by other applications.

alperozturk96 · 2025-01-14T07:49:48Z

@tobiasKaminsky How can you suppress this or maybe reduce the condition count?

Signed-off-by: tobiasKaminsky <[email protected]> Signed-off-by: alperozturk <[email protected]>

Signed-off-by: github-actions <[email protected]> Signed-off-by: alperozturk <[email protected]>

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Tobias Kaminsky <[email protected]> Signed-off-by: alperozturk <[email protected]>

…ationPermission when user pressed the close button Signed-off-by: alperozturk <[email protected]>

Co-authored-by: Tom <[email protected]> Signed-off-by: Tobias Kaminsky <[email protected]> Signed-off-by: alperozturk <[email protected]>

Signed-off-by: tobiasKaminsky <[email protected]> Signed-off-by: alperozturk <[email protected]>

Signed-off-by: alperozturk <[email protected]>

github-actions · 2025-01-14T08:28:52Z

Codacy

Lint

Type	master	PR
Warnings	56	55
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	65	65
Correctness	58	58
Dodgy code	296	294
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	1	1
Multithreaded correctness	7	7
Performance	53	53
Security	18	18
Total	506	504

github-actions · 2025-01-14T08:30:50Z

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14247.apk

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

tobiasKaminsky added the 2. developing label Dec 27, 2024

tobiasKaminsky force-pushed the media_permission branch from 42e0bfd to 45e091e Compare December 27, 2024 07:50

tobiasKaminsky mentioned this pull request Dec 27, 2024

3.30.6 - Missing permission "all files access" #14135

Open

4 tasks done

BluePixel4k mentioned this pull request Dec 27, 2024

Automatic Upload Issue on Nextcloud Android Client (v3.30.6) - Android permissions lost after update #14199

Closed

4 tasks done

r3df0chs mentioned this pull request Dec 27, 2024

Sharing images from other apps removes EXIF location on Android > 10 #6248

Open

BluePixel4k mentioned this pull request Jan 1, 2025

gplay release outdated (3.29.2 instead of 3.30.3) #13871

Closed

backportbot Bot added the backport-request label Jan 9, 2025

tobiasKaminsky mentioned this pull request Jan 9, 2025

Inform users that Auto Uploads are not working after upgrading to version 3.30.6 or later #14349

Open

tobiasKaminsky mentioned this pull request Jan 10, 2025

GPS Coordinates not being uploaded via Auto Upload ONLY #14251

Open

4 tasks done

tobiasKaminsky force-pushed the media_permission branch from 7879bc4 to 89df990 Compare January 13, 2025 10:26

tobiasKaminsky marked this pull request as ready for review January 13, 2025 10:27

tobiasKaminsky added 3. to review and removed 2. developing labels Jan 13, 2025

alperozturk96 requested changes Jan 13, 2025

View reviewed changes

github-advanced-security AI found potential problems Jan 13, 2025

View reviewed changes

alperozturk96 force-pushed the media_permission branch from 3fc5660 to f2307d5 Compare January 13, 2025 15:09

alperozturk96 added this to the Nextcloud App 3.30.8 milestone Jan 13, 2025

alperozturk96 force-pushed the media_permission branch from f5f8584 to 4e34e75 Compare January 13, 2025 15:27

ZetaTom requested changes Jan 13, 2025

View reviewed changes

alperozturk96 force-pushed the media_permission branch 2 times, most recently from 2957d11 to 15e5511 Compare January 14, 2025 07:35

alperozturk96 approved these changes Jan 14, 2025

View reviewed changes

tobiasKaminsky and others added 11 commits January 14, 2025 09:20

request media_location

0a3904b

Signed-off-by: tobiasKaminsky <[email protected]> Signed-off-by: alperozturk <[email protected]>

show more info about permissions

1aacaf3

Signed-off-by: tobiasKaminsky <[email protected]> Signed-off-by: alperozturk <[email protected]>

request media_location

0d1456f

Signed-off-by: tobiasKaminsky <[email protected]> Signed-off-by: alperozturk <[email protected]>

Show more info about auto upload on GPlay

e3e9da3

Signed-off-by: tobiasKaminsky <[email protected]> Signed-off-by: alperozturk <[email protected]>

fixes after review

cef0410

Signed-off-by: tobiasKaminsky <[email protected]> Signed-off-by: alperozturk <[email protected]>

Analysis: update lint results to reflect reduced error/warning count

cf11dc8

Signed-off-by: github-actions <[email protected]> Signed-off-by: alperozturk <[email protected]>

Fix code scanning alert no. 243: Use of implicit PendingIntents

a35f230

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Tobias Kaminsky <[email protected]> Signed-off-by: alperozturk <[email protected]>

no need to request external storage permission again, requestMediaLoc…

f5af080

…ationPermission when user pressed the close button Signed-off-by: alperozturk <[email protected]>

Update app/src/main/res/values/strings.xml

bbf5687

Co-authored-by: Tom <[email protected]> Signed-off-by: Tobias Kaminsky <[email protected]> Signed-off-by: alperozturk <[email protected]>

update due to code review

523bfd3

Signed-off-by: tobiasKaminsky <[email protected]> Signed-off-by: alperozturk <[email protected]>

fix code analytics

12b3fff

Signed-off-by: alperozturk <[email protected]>

alperozturk96 force-pushed the media_permission branch from 15e5511 to 12b3fff Compare January 14, 2025 08:20

tobiasKaminsky merged commit 0abff31 into master Jan 14, 2025

tobiasKaminsky deleted the media_permission branch January 14, 2025 08:46

backportbot Bot mentioned this pull request Jan 14, 2025

[stable-3.30] request media_location #14401

Merged

backportbot Bot removed the backport-request label Jan 14, 2025

@@ -209,3 +209,4 @@
                     val notificationId = randomIdGenerator.nextInt()
-                    val intent = Intent(context, FileDisplayActivity::class.java).apply {
+                    val intent = Intent().apply {
+                        setClassName(context, FileDisplayActivity::class.java.name)
                         setAction(FileDisplayActivity.AUTO_UPLOAD_NOTIFICATION)

Conversation

tobiasKaminsky commented Dec 27, 2024 • edited by alperozturk96 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BluePixel4k commented Jan 1, 2025

Uh oh!

hw-hass23 commented Jan 2, 2025

Uh oh!

tobiasKaminsky commented Jan 9, 2025

Uh oh!

tobiasKaminsky commented Jan 9, 2025

Uh oh!

Whisprin commented Jan 9, 2025

Uh oh!

Whisprin commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alperozturk96 commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Check failure

Copilot Autofix

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alperozturk96 commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 14, 2025

Codacy

Lint

SpotBugs

Uh oh!

github-actions Bot commented Jan 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

tobiasKaminsky commented Dec 27, 2024 •

edited by alperozturk96

Loading

Whisprin commented Jan 9, 2025 •

edited

Loading

alperozturk96 commented Jan 13, 2025 •

edited

Loading

alperozturk96 commented Jan 14, 2025 •

edited

Loading