Repository navigation
Start audio player using foreground service API on Android 26+ - #6798
Merged
tobiasKaminsky merged 1 commit intoSep 2, 2020
Merged
tobiasKaminsky merged 1 commit into
tobiasKaminsky merged 1 commit into
Conversation
Collaborator
Author
|
@AndyScherzinger @tobiasKaminsky |
ezaquarii
changed the title
ezaquarii
force-pushed
the
ezaquarii/fix-illegal-state-exception-when-stopping-audio-player
branch
2 times, most recently
from
August 25, 2020 17:43
b6d737b to
9c7cb6c
Compare
Collaborator
Author
|
@tobiasKaminsky @AndyScherzinger |
ezaquarii
force-pushed
the
ezaquarii/fix-illegal-state-exception-when-stopping-audio-player
branch
from
August 25, 2020 17:46
9c7cb6c to
3c0157c
Compare
ezaquarii
changed the title
On API 26+ (Oreo, 8.0) running background services is restricted by power saving mechanisms, causing occasional IllegalStateException when service intent is rejected by the OS. Migrate to startForegroundService API to mitigate this problem. Audio player service is foreground by design. Fixes #6665 Signed-off-by: Chris Narkiewicz <[email protected]>
ezaquarii
force-pushed
the
ezaquarii/fix-illegal-state-exception-when-stopping-audio-player
branch
from
August 25, 2020 17:55
3c0157c to
6feedf8
Compare
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15565.apk |
Codecov Report
@@ Coverage Diff @@
## master #6798 +/- ##
============================================
- Coverage 27.76% 27.76% -0.01%
Complexity 5 5
============================================
Files 427 427
Lines 34251 34254 +3
Branches 4735 4735
============================================
Hits 9511 9511
- Misses 23323 23327 +4
+ Partials 1417 1416 -1
|
Collaborator
Codacy408Lint
SpotBugs (new)
SpotBugs (master)
|
tobiasKaminsky
approved these changes
Sep 2, 2020
delete-merged-branch
Bot
deleted the
ezaquarii/fix-illegal-state-exception-when-stopping-audio-player
branch
September 2, 2020 07:04
This was referenced Sep 8, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start audio player using foreground service API on Android 26+
On API 26+ (Oreo, 8.0) running background services is restricted
by power saving mechanisms, causing occasional IllegalStateException
when service intent is rejected by the OS.
Migrate to startForegroundService API to mitigate this problem.
Audio player service is foreground by design.
Fixes #6665
Signed-off-by: Chris Narkiewicz [email protected]