Set status by tobiasKaminsky · Pull Request #7149 · nextcloud/android

tobiasKaminsky · 2020-10-27T09:30:44Z

Testing

Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.

unit tests
instrumented tests
UI tests

Tests written, or not not needed

nextcloud-android-bot · 2020-10-29T11:48:02Z

Here is an overview of what got changed by this pull request:

Issues
======
- Added 10
           

Complexity increasing per file
==============================
- src/main/java/com/owncloud/android/ui/StatusDrawable.java  5
- src/main/java/com/owncloud/android/ui/asynctasks/RetrieveStatusAsyncTask.java  2
- src/main/java/com/owncloud/android/providers/FileContentProvider.java  3
- src/main/java/com/owncloud/android/providers/UsersAndGroupsSearchProvider.java  13
- src/main/java/com/owncloud/android/utils/DisplayUtils.java  2
         

Clones added
============
- src/main/java/com/nextcloud/ui/SetStatusTask.kt  1
- src/main/java/com/nextcloud/ui/SetUserDefinedCustomStatusTask.kt  4
- src/main/java/com/nextcloud/ui/SetPredefinedCustomStatusTask.kt  2
- src/main/java/com/nextcloud/ui/ClearStatusTask.kt  1

See the complete overview on Codacy

nextcloud-android-bot · 2020-10-29T11:48:12Z

+            NextcloudClient client = clientFactory.createNextcloudClient(user);
+            RemoteOperationResult result = new GetStatusRemoteOperation().execute(client);
+
+            return (com.owncloud.android.lib.resources.users.Status) result.getSingleData();


Codacy found an issue: Unnecessary use of fully qualified name 'com.owncloud.android.lib.resources.users.Status' due to existing import 'com.owncloud.android.lib.resources.users.Status'

nextcloud-android-bot · 2020-10-29T11:48:13Z

+
+                default:
+                    // do not show
+                    backgroundPaint = null;


Codacy found an issue: Assigning an Object to null is a code smell. Consider refactoring.

nextcloud-android-bot · 2020-10-29T11:48:14Z

+                                            statusObject.isNull("icon") ? "" : statusObject.getString("icon"),
+                                            statusObject.isNull("clearAt") ? -1 : statusObject.getLong("clearAt"));
+                    } else {
+                        status = new Status(StatusType.OFFLINE, "", "", -1);


Codacy found an issue: Avoid instantiating new objects inside loops

nextcloud-android-bot · 2020-10-29T11:48:15Z

+            byte[] bitmapData = bos.toByteArray();
+
+            //write the bytes in file
+            try (FileOutputStream fos = new FileOutputStream(f)) {


Codacy found an issue: Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter

nextcloud-android-bot · 2020-10-29T11:48:16Z

                        case USER:
                            displayName = userName;
-                            icon = R.drawable.ic_user;
+                            subline = status.getMessage().isEmpty() ? null : status.getMessage();


Codacy found an issue: Assigning an Object to null is a code smell. Consider refactoring.

nextcloud-android-bot · 2020-10-29T11:48:17Z

     */
    private float mRadius;

+    private boolean bigText = false;


Codacy found an issue: Avoid using redundant field initializer for 'bigText'

nextcloud-android-bot · 2020-10-29T11:48:18Z

+    }
+
+    @Override
+    protected void onPostExecute(com.owncloud.android.lib.resources.users.Status status) {


Codacy found an issue: Unnecessary use of fully qualified name 'com.owncloud.android.lib.resources.users.Status' due to existing import 'com.owncloud.android.lib.resources.users.Status'

nextcloud-android-bot · 2020-10-29T11:48:19Z

+                    JSONObject statusObject = item.optJSONObject("status");
+
+                    if (statusObject != null) {
+                        status = new Status(StatusType.valueOf(statusObject.getString("status")),


Codacy found an issue: Avoid instantiating new objects inside loops

nextcloud-android-bot · 2020-10-29T11:48:20Z

+    }
+
+    @Override
+    protected com.owncloud.android.lib.resources.users.Status doInBackground(Void... voids) {


Codacy found an issue: Unnecessary use of fully qualified name 'com.owncloud.android.lib.resources.users.Status' due to existing import 'com.owncloud.android.lib.resources.users.Status'

nextcloud-android-bot · 2020-10-29T11:48:21Z

+            return (com.owncloud.android.lib.resources.users.Status) result.getSingleData();
+
+        } catch (ClientFactory.CreationException e) {
+            return new com.owncloud.android.lib.resources.users.Status(StatusType.OFFLINE, "", "", -1);


Codacy found an issue: Unnecessary use of fully qualified name 'com.owncloud.android.lib.resources.users.Status' due to existing import 'com.owncloud.android.lib.resources.users.Status'

Signed-off-by: tobiasKaminsky <[email protected]>

Signed-off-by: Andy Scherzinger <[email protected]>

Signed-off-by: tobiasKaminsky <[email protected]>

Signed-off-by: Andy Scherzinger <[email protected]>

Signed-off-by: tobiasKaminsky <[email protected]>

Signed-off-by: Andy Scherzinger <[email protected]>

Signed-off-by: tobiasKaminsky <[email protected]>

Signed-off-by: Andy Scherzinger <[email protected]>

nextcloud-android-bot · 2020-10-29T22:20:35Z

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16384.apk

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

nextcloud-android-bot · 2020-10-29T22:32:22Z

master-light-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16384-Screenshot-master-light-blue

nextcloud-android-bot · 2020-10-29T22:36:11Z

Codacy

Lint

Type	master	PR
Warnings	337	334
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	53
Internationalization Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	72
Security Warnings	43
Dodgy code Warnings	102
Total	315

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	53
Internationalization Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	72
Security Warnings	43
Dodgy code Warnings	102
Total	315

nextcloud-android-bot · 2020-10-29T22:36:31Z

stable-light-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16384-Screenshot-stable-light-blue

nextcloud-android-bot · 2020-10-29T22:46:57Z

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16384-IT-master

nextcloud-android-bot · 2020-10-29T22:48:54Z

master-dark-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16384-Screenshot-master-dark-blue

nextcloud-android-bot · 2020-10-29T22:53:30Z

stable-dark-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16384-Screenshot-stable-dark-blue

Set status Signed-off-by: thelittlefireman <[email protected]>

tobiasKaminsky added the 3. to review label Oct 27, 2020

tobiasKaminsky mentioned this pull request Oct 27, 2020

Feature Parity: User Status nextcloud/server#22452

Closed

4 tasks done

AndyScherzinger force-pushed the setStatus branch 3 times, most recently from adba8f0 to 45ad179 Compare October 27, 2020 12:42

tobiasKaminsky force-pushed the setStatus branch from 45ad179 to f3522a8 Compare October 28, 2020 12:27

tobiasKaminsky added this to the Nextcloud App 3.14.0 milestone Oct 28, 2020

nextcloud-android-bot reviewed Oct 29, 2020

View reviewed changes

tobiasKaminsky and others added 12 commits October 29, 2020 20:27

Add status to sharee

dbd9e6f

Signed-off-by: tobiasKaminsky <[email protected]>

Remove unneeded empty lines

d642da4

Signed-off-by: Andy Scherzinger <[email protected]>

user proper license header format

4d5eb12

Signed-off-by: Andy Scherzinger <[email protected]>

proper kotlin enum naming pattern

96680fd

Signed-off-by: Andy Scherzinger <[email protected]>

remove var prefixes

711b233

Signed-off-by: Andy Scherzinger <[email protected]>

improve detekt score

9741cf2

Signed-off-by: Andy Scherzinger <[email protected]>

proper comment formatting

4fed61d

Signed-off-by: Andy Scherzinger <[email protected]>

wip

dcc246f

Signed-off-by: tobiasKaminsky <[email protected]>

wip

0709076

Signed-off-by: tobiasKaminsky <[email protected]>

wip

c09fa8c

Signed-off-by: tobiasKaminsky <[email protected]>

wip

0bb5ad6

Signed-off-by: tobiasKaminsky <[email protected]>

wip

bff08bb

Signed-off-by: tobiasKaminsky <[email protected]>

tobiasKaminsky and others added 5 commits October 29, 2020 20:27

wip

ad5ca22

Signed-off-by: tobiasKaminsky <[email protected]>

wip

fcb0147

Signed-off-by: tobiasKaminsky <[email protected]>

improved layouting

f802cb3

Signed-off-by: Andy Scherzinger <[email protected]>

wip

4244a50

Signed-off-by: tobiasKaminsky <[email protected]>

emoji

21fbb68

Signed-off-by: tobiasKaminsky <[email protected]>

AndyScherzinger force-pushed the setStatus branch from 75d71b4 to e8cfaaf Compare October 29, 2020 19:27

AndyScherzinger and others added 5 commits October 29, 2020 20:28

set texts and move to view binding

fba718a

Signed-off-by: Andy Scherzinger <[email protected]>

optimize status dialog layout, add status active visual

8369e4c

Signed-off-by: Andy Scherzinger <[email protected]>

wip

7d7a80a

Signed-off-by: tobiasKaminsky <[email protected]>

fix lint

0b8cf61

Signed-off-by: tobiasKaminsky <[email protected]>

Spotbugs

6d1d4a7

Signed-off-by: tobiasKaminsky <[email protected]>

AndyScherzinger force-pushed the setStatus branch from e8cfaaf to 6d1d4a7 Compare October 29, 2020 19:29

add dark screenshots

a542bee

Signed-off-by: Andy Scherzinger <[email protected]>

AndyScherzinger merged commit fb7fd8c into master Oct 29, 2020

delete-merged-branch Bot deleted the setStatus branch October 29, 2020 22:56

thelittlefireman pushed a commit to thelittlefireman/android that referenced this pull request Mar 19, 2021

Merge pull request nextcloud#7149 from nextcloud/setStatus

4029f6a

Set status Signed-off-by: thelittlefireman <[email protected]>

Conversation

tobiasKaminsky commented Oct 27, 2020

Testing

Uh oh!

nextcloud-android-bot commented Oct 29, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nextcloud-android-bot commented Oct 29, 2020

Uh oh!

nextcloud-android-bot commented Oct 29, 2020

Uh oh!

nextcloud-android-bot commented Oct 29, 2020

Codacy

Lint

SpotBugs (new)

SpotBugs (master)

Uh oh!

nextcloud-android-bot commented Oct 29, 2020

Uh oh!

nextcloud-android-bot commented Oct 29, 2020

Uh oh!

nextcloud-android-bot commented Oct 29, 2020

Uh oh!

nextcloud-android-bot commented Oct 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants