Skip to content

Added the possibility to upload a Public GPG key. - #460

Closed
tacruc wants to merge 1 commit into
nextcloud:masterfrom
tacruc:GPG-Pubkey
Closed

tacruc wants to merge 1 commit into
nextcloud:masterfrom
tacruc:GPG-Pubkey

Conversation

@tacruc

@tacruc tacruc commented Jan 22, 2018

Copy link
Copy Markdown
Contributor

This PR is depending on nextcloud/server#7997. It addes the possibility to add public key or an link on a key to an vCard.

@skjnldsv skjnldsv added 2. developing Work in progress enhancement New feature or request labels Mar 11, 2018
@skjnldsv

Copy link
Copy Markdown
Member

Hello there! :)
Sorry for the late feedback! Could you add some verification in this? Since we're suppose to accept a valid base64, It could be great to ensure that the text is always encoded.

Also, the key indicator should probably have a data:application/pgp-keys;base64 attached for better handling by other apps :)
https://tools.ietf.org/html/rfc6350#section-6.8.1

@tacruc

tacruc commented Mar 11, 2018

Copy link
Copy Markdown
Contributor Author

@skjnldsv thanks for the feedback.

Which files would be the right place to add the base64 check?
Should it just be added in templates/detailItems/key.html?

And for the key indication data:application/pgp-keys;base64 while implementing, but somehow failed to encode it in the given strukture.
So I lookt for alternatives and found this one in https://en.wikipedia.org/wiki/VCard

I but I see your point and will have a look into this, if it is clear what is going to happen to the dependency PR on the server side.

@skjnldsv

skjnldsv commented Oct 1, 2018

Copy link
Copy Markdown
Member

@tacruc sorry for the very late delay.
Because we planned to upgrade this app to vue we couldn't merge your pr.

We'll try to add this feature into 3.1.0 :)

@skjnldsv skjnldsv closed this Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants