Skip to content

Gpg Contacts - #7997

Closed
tacruc wants to merge 22 commits into
nextcloud:masterfrom
tacruc:GPG-Contacts
Closed

tacruc wants to merge 22 commits into
nextcloud:masterfrom
tacruc:GPG-Contacts

Conversation

@tacruc

@tacruc tacruc commented Jan 22, 2018 •

Copy link
Copy Markdown
Contributor

This PR is depending on #7996
Now interface is used to extend the Contacts Backend so that public key's form contacts vCard are imported. Changes to the Contacts app can be found here: nextcloud/contacts#460

This PR is set of more Ideas:

Issue: #7310 and the Community
https://help.nextcloud.com/t/gpg-encrypted-emails-for-nextcloud/26129/4

IGpg and email (the basement)

#7996

Use the key from the Contacts to encrypt "share by email" emails

still allot to do
Server Branch: https://github.com/tacruc/server/tree/GPG-Share-By-eMail

More key managment features

There is an app https://github.com/tacruc/keymanager providing more features, but I'm not a desinger or a HTML/Javascript person so help with the interface would be appriciated

  • Providing an overview over all key's
  • showing contacts connected to a key (only in the json file)
  • suggesting contacts to connect with an key (only in the json file)
  • deleting and revoking keys
  • much more ...

@tacruc tacruc changed the title Gpg contacts Gpg Contacts Jan 22, 2018
tacruc added 22 commits January 25, 2018 15:50
The IMessages now accepts an array of Key fingerprints to encrypt and
sing and the Mailer calls an encryption funktion on sending.

Added IMessage_sign() to sign the email
Signed-off-by: Arne Hamann <[email protected]>
and Signed when Public and Private key are provided. This is tested on
mailbox.org and Outlook with GPGOL as client.

Signatur of email works on gmail and mailbox.org but fails on outlook.

Signed-off-by: Arne Hamann <[email protected]>
email Text extraction with messageContentToString funktion.

Signed-off-by: Arne Hamann <[email protected]>
… personal

setting page. More keys can be saved and are shown in the page too, it
is not nice so I think i will remove the showing. The backend for
multiple keys is importanted for futher applications.

Signed-off-by: Arne Hamann <[email protected]>
messages update log message to not leak unencrypted messages..

Signed-off-by: Arne Hamann <[email protected]>
…Keys

and OCP\Gpg. IGpg interface can now handle nonempty phassphrases
Signed-off-by: Arne Hamann <[email protected]>
Systems gpg and add a fingerprint as X-KEY-FINGERPRINT to the vCard.
FIXME: addded X-KEY-FINGERPRINT is not shown in downloaded vCard.
Converter from user to vCard adds Keys and Fingerprints to vCard.

Signed-off-by: Arne Hamann <[email protected]>
the public key will be downloaded and imported to System GPG.

Signed-off-by: Arne Hamann <[email protected]>
Signed-off-by: Arne Hamann <[email protected]>
@codecov

codecov Bot commented Jan 25, 2018

Copy link
Copy Markdown

Codecov Report

Merging #7997 into master will increase coverage by 5.92%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7997      +/-   ##
============================================
+ Coverage     51.22%   57.15%   +5.92%     
============================================
  Files          1598       65    -1533     
  Lines         94922     7800   -87122     
  Branches       1376     1376              
============================================
- Hits          48625     4458   -44167     
+ Misses        46297     3342   -42955
Impacted Files Coverage Δ Complexity Δ
...ser_ldap/composer/composer/autoload_namespaces.php
apps/files/lib/Capabilities.php
...onnector/composer/composer/autoload_namespaces.php
apps/encryption/lib/KeyManager.php
config/config.sample.php
apps/admin_audit/lib/Actions/AppManagement.php
lib/private/Files/Node/LazyRoot.php
...b/public/AppFramework/Http/FileDisplayResponse.php
apps/files_sharing/appinfo/routes.php
...p_server_connector/lib/BackgroundJobs/RetryJob.php
... and 1506 more

@rullzer

rullzer commented May 23, 2018

Copy link
Copy Markdown
Member

See #7996 (comment)

@rullzer rullzer closed this May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants